Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-1931: Update description in CSV (#1008) #1027

Merged
merged 2 commits into from May 22, 2023
Merged

OADP-1931: Update description in CSV (#1008) #1027

merged 2 commits into from May 22, 2023

Conversation

rayfordj
Copy link
Contributor

OADP-1931 Improve Cluster Service Version YAML's Description fields

Incorporate feedback from comment

@rayfordj rayfordj self-assigned this May 22, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2023 •
edited by openshift-ci bot

@rayfordj: This pull request references OADP-1931 which is a valid jira issue.

In response to this:

OADP-1931 Improve Cluster Service Version YAML's Description fields

Incorporate feedback from comment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from eemcmullan May 22, 2023 13:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels May 22, 2023
kaovilai
kaovilai approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, rayfordj, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,rayfordj,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6647933 and 2 for PR HEAD 772e93a in total

@rayfordj
Copy link
Contributor Author

/retest-required

@rayfordj
Copy link
Contributor Author

/retest 4.11-operator-e2e-azure

@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

@rayfordj: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test 4.10-ci-index
  • /test 4.10-images
  • /test 4.10-operator-e2e-aws
  • /test 4.10-operator-e2e-azure
  • /test 4.10-operator-e2e-gcp
  • /test 4.10-operator-unit-test
  • /test 4.11-ci-index
  • /test 4.11-images
  • /test 4.11-operator-e2e-aws
  • /test 4.11-operator-e2e-azure
  • /test 4.11-operator-e2e-gcp
  • /test 4.11-operator-unit-test

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-oadp-operator-master-4.10-ci-index
  • pull-ci-openshift-oadp-operator-master-4.10-images
  • pull-ci-openshift-oadp-operator-master-4.10-operator-e2e-aws
  • pull-ci-openshift-oadp-operator-master-4.10-operator-e2e-azure
  • pull-ci-openshift-oadp-operator-master-4.10-operator-e2e-gcp
  • pull-ci-openshift-oadp-operator-master-4.11-ci-index
  • pull-ci-openshift-oadp-operator-master-4.11-images
  • pull-ci-openshift-oadp-operator-master-4.11-operator-e2e-aws
  • pull-ci-openshift-oadp-operator-master-4.11-operator-e2e-azure
  • pull-ci-openshift-oadp-operator-master-4.11-operator-e2e-gcp
  • pull-ci-openshift-oadp-operator-master-4.11-operator-unit-test

In response to this:

/retest 4.11-operator-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayfordj
Copy link
Contributor Author

/test 4.11-operator-e2e-azure

@rayfordj
Copy link
Contributor Author

/cherry-pick oadp-1.2

@openshift-cherrypick-robot
Copy link
Contributor

@rayfordj: once the present PR merges, I will cherry-pick it on top of oadp-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayfordj
Copy link
Contributor Author

/test 4.11-operator-e2e-gcp
/test 4.10-operator-e2e-azure
/test 4.10-operator-e2e-gcp

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 158823a and 1 for PR HEAD 772e93a in total

@weshayutin weshayutin merged commit d4a0972 into openshift:master May 22, 2023
5 of 12 checks passed
@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

@rayfordj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-operator-e2e-azure 772e93a link true /test 4.11-operator-e2e-azure
ci/prow/4.11-operator-e2e-gcp 772e93a link true /test 4.11-operator-e2e-gcp
ci/prow/4.10-operator-e2e-gcp 772e93a link true /test 4.10-operator-e2e-gcp
ci/prow/4.10-operator-e2e-azure 772e93a link true /test 4.10-operator-e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 22, 2023
Merged
@openshift-cherrypick-robot
Copy link
Contributor

@rayfordj: new pull request created: #1029

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayfordj rayfordj deleted the oadp-1931-master branch May 23, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sseago sseago sseago approved these changes

@kaovilai kaovilai kaovilai approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@weshayutin weshayutin Awaiting requested review from weshayutin

@dymurray dymurray Awaiting requested review from dymurray

@eemcmullan eemcmullan Awaiting requested review from eemcmullan

Assignees

@sseago sseago

@rayfordj rayfordj

@kaovilai kaovilai

@shubham-pampattiwar shubham-pampattiwar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rayfordj @openshift-ci-robot @openshift-cherrypick-robot @sseago @kaovilai @shubham-pampattiwar @weshayutin