operator sdk upgrade chores #1202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.14.0/ Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.16.0/#bump-operator_sdkutil-in-requirementsyml Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.17.0/#gov3-upgrade-go-and-dependencies Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.18.0/#support-image-digests-instead-of-tags Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.21.0/ Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.22.0/ Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.23.0/ Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.25.0/ Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.28.0/ Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> upgrade k8s to 1.26 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
force-pushed
the
operator-sdk-chores
branch
from
a243e4a
to
c6b86f1
Compare
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> `make bundle` Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
force-pushed
the
operator-sdk-chores
branch
from
c6b86f1
to
3217a9c
Compare
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
force-pushed
the
operator-sdk-chores
branch
2 times, most recently
from
2383cc5
to
ec3a350
Compare
kaovilai
force-pushed
the
operator-sdk-chores
branch
from
ec3a350
to
96e847a
Compare
kaovilai
commented
Oct 27, 2023
Comment on lines
+9
to
+33
| resources: | ||
| - api: | ||
| crdVersion: v1 | ||
| namespaced: true | ||
| controller: true | ||
| domain: openshift.io | ||
| group: oadp | ||
| kind: DataProtectionApplication | ||
| path: github.com/openshift/oadp-operator/api/v1alpha1 | ||
| version: v1alpha1 | ||
| webhooks: | ||
| defaulting: true | ||
| webhookVersion: v1 | ||
| - api: | ||
| crdVersion: v1 | ||
| namespaced: true | ||
| controller: true | ||
| domain: openshift.io | ||
| group: oadp | ||
| kind: CloudStorage | ||
| path: github.com/openshift/oadp-operator/api/v1alpha1 | ||
| version: v1alpha1 | ||
| webhooks: | ||
| defaulting: true | ||
| webhookVersion: v1 |
There was a problem hiding this comment.
This is a pre-requisite to get CSV owned generation to work.
|
These places Do you know how operator sdk code was first generated? If yes, we could try this approach dora-metrics/pelorus#1045 |
|
probably some init commands when operator-sdk used was about v1.12 or so. |
kaovilai
added
the
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kaovilai: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hold for experiments
Approximately keeping Makefile in-line with latest operator-sdk via following https://sdk.operatorframework.io/docs/upgrading-sdk-version/ upgrade migrations
Why:
figuring out if this helps
make bundleupdate theclusterserviceversion.spec.customresourcedefinitions.owned[]git/operator-sdk/testdata/go/v3/memcached-operator is working, still digging why this repo is not working.
Discoveries
Operator UI can be customizable somewhat with x-descriptors
https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md
which if one authors the x_type.go can be added for generation like so
+operator-sdk:csv:customresourcedefinitions:type=[spec,status],xDescriptors={"urn:alm:descriptor:com.tectonic.ui:podCount","urn:alm:descriptor:io.kubernetes:custom"}Otherwise, such as in Velero CRD case, you can manually specify them in config/manifests/oadp-operator.clusterserviceversion.yaml
These descriptors were previously added manually