Bug 1879878: remove logging when authz header is present but basic auth is not attempted #197
Conversation
|
@stlaz: This pull request references Bugzilla bug 1879878, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
openshift-ci-robot
added
the
approved
|
/retest |
| @@ -840,7 +840,7 @@ func (p *OAuthProxy) CheckBasicAuth(req *http.Request) (*providers.SessionState, | |||
| } | |||
| s := strings.SplitN(auth, " ", 2) | |||
| if len(s) != 2 || s[0] != "Basic" { | |||
| return nil, fmt.Errorf("Authorization header does not start with 'Basic', skipping basic authentication") | |||
| return nil, nil | |||
There was a problem hiding this comment.
add go doc what this func's return values mean. I assume nil is not "accept".
|
@sttts added the requested godoc |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stlaz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stlaz: All pull requests linked via external trackers have merged: Bugzilla bug 1879878 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.6 |
|
@stlaz: new pull request created: #200 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@stlaz: new pull request created: #201 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @sttts