Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTH-373: add audit-ID headers to TokenReview and SAR requests #252

Merged
merged 8 commits into from May 31, 2023
Merged

AUTH-373: add audit-ID headers to TokenReview and SAR requests #252

merged 8 commits into from May 31, 2023

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Mar 15, 2023

Adds an Audit-ID header to help troubleshoot TokenReview and SAR issues.

Also PR bumps the golang build image, kube and lib-go.

/cc @deads2k @ibihim

@openshift-ci openshift-ci bot requested review from deads2k and ibihim March 15, 2023 15:13
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@deads2k
Copy link

deads2k commented Mar 15, 2023

once we show this installing, @dgoodwin could you/forrest kick the correct /payload job for 4.14 to see these lines appear?

@dgoodwin
Copy link

/payload 4.14 ci blocking

@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2023

@dgoodwin: trigger 4 job(s) of type blocking for the ci release of OCP 4.14

  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a316e6d0-c3fe-11ed-98bd-4daf04ae1e93-0

@stlaz
Copy link
Member Author

stlaz commented Mar 16, 2023

something broke during the bump, let me try to fix that

@stlaz
Copy link
Member Author

stlaz commented Mar 17, 2023

/payload 4.14 ci blocking

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2023

@stlaz: trigger 4 job(s) of type blocking for the ci release of OCP 4.14

  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/626ad490-c4b0-11ed-9e55-a48e9f12e7ac-0

@stlaz
Copy link
Member Author

stlaz commented Mar 20, 2023

/test e2e-component

@stlaz
Copy link
Member Author

stlaz commented Mar 20, 2023

/test e2e-component
installation issue

1 similar comment
@stlaz
Copy link
Member Author

stlaz commented Mar 22, 2023

/test e2e-component
installation issue

@stlaz
Copy link
Member Author

stlaz commented Mar 22, 2023

/test e2e-component

@stlaz
Copy link
Member Author

stlaz commented Mar 24, 2023

/test e2e-component
unrelated

ibihim
ibihim reviewed Apr 5, 2023
View reviewed changes
providers/openshift/authentication.go
func auditIDRountripper(rt http.RoundTripper) http.RoundTripper {
return roundTripFunc(func(r *http.Request) (*http.Response, error) {
auditID := uuid.New().String()
r.Header.Add("Audit-ID", auditID)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to check if the header is already set, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that might actually be useful, good point

ibihim
ibihim approved these changes Apr 20, 2023
View reviewed changes
Copy link

@ibihim ibihim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibihim, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stlaz
Copy link
Member Author

stlaz commented Apr 20, 2023

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2023

@stlaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stlaz stlaz changed the title add audit-ID headers to TokenReview and SAR requests AUTH-373: add audit-ID headers to TokenReview and SAR requests May 4, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2023 •
edited by openshift-ci bot

@stlaz: This pull request references AUTH-373 which is a valid jira issue.

In response to this:

Adds an Audit-ID header to help troubleshoot TokenReview and SAR issues.

Also PR bumps the golang build image, kube and lib-go.

/cc @deads2k @ibihim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neisw
Copy link

neisw commented May 30, 2023

/payload 4.14 ci blocking

@openshift-ci
Copy link

openshift-ci bot commented May 30, 2023

@neisw: trigger 4 job(s) of type blocking for the ci release of OCP 4.14

  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/da175e30-ff04-11ed-91a1-88921c6eba1f-0

@neisw
Copy link

neisw commented May 31, 2023

/payload 4.14 ci blocking

@openshift-ci
Copy link

openshift-ci bot commented May 31, 2023

@neisw: trigger 4 job(s) of type blocking for the ci release of OCP 4.14

  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f5e7b7e0-ff4a-11ed-81b3-9a0cfb6ec350-0

@stbenjam
Copy link
Member

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit 59ac35d into openshift:master May 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibihim ibihim ibihim approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@ibihim ibihim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@stlaz @deads2k @dgoodwin @openshift-ci-robot @neisw @stbenjam @ibihim @openshift-merge-robot