-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support KUBERNETES_SERVICE_PORT environment variable #254
Conversation
The `KUBERNETES_SERVICE_HOST` environment variable does not support allowing the user to specify a custom port because it thinks the value is an IPv6 address and wraps in in square brackets. This change adds support for a second environment variable `KUBERNETES_SERVICE_PORT` to accommodate this situation.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: darwish The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @darwish. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The
KUBERNETES_SERVICE_HOST
environment variable does not support allowing the user to specify a custom port because it thinks the value is an IPv6 address and wraps in in square brackets.This change adds support for a second environment variable
KUBERNETES_SERVICE_PORT
to accommodate this situation.