Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14033: Handle TERM signal gracefully #255

Merged

Conversation

simonpasquier
Copy link

When a pod is evicted, the container runtime will send a TERM signal to the PID 1 of all containers. If a container doesn't catch the signal, the process will exit with a non-zero code and Kubernetes might consider the pod status to be Failed.

See
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 31, 2023
@openshift-ci-robot
Copy link

@simonpasquier: This pull request references Jira Issue OCPBUGS-14033, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When a pod is evicted, the container runtime will send a TERM signal to the PID 1 of all containers. If a container doesn't catch the signal, the process will exit with a non-zero code and Kubernetes might consider the pod status to be Failed.

See
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao May 31, 2023 14:38
@simonpasquier
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2023
@openshift-ci openshift-ci bot requested review from deads2k and stlaz May 31, 2023 14:49
@simonpasquier
Copy link
Author

/test e2e-component

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2023
When a pod is evicted, the container runtime will send a TERM signal to
the PID 1 of all containers. If a container doesn't catch the signal,
the process will exit with a non-zero code and Kubernetes might consider
the pod status to be Failed.

See
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier
Copy link
Author

/test e2e-component

@simonpasquier
Copy link
Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2023
@simonpasquier
Copy link
Author

/assign @stlaz

@simonpasquier
Copy link
Author

/test e2e-component

1 similar comment
@simonpasquier
Copy link
Author

/test e2e-component

@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2023

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link

deads2k commented Jun 1, 2023

should help us exit cleanly. wiring missed http

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit bb6c702 into openshift:master Jun 1, 2023
7 checks passed
@openshift-ci-robot
Copy link

@simonpasquier: Jira Issue OCPBUGS-14033: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-14033 has not been moved to the MODIFIED state.

In response to this:

When a pod is evicted, the container runtime will send a TERM signal to the PID 1 of all containers. If a container doesn't catch the signal, the process will exit with a non-zero code and Kubernetes might consider the pod status to be Failed.

See
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants