Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login templates to PatternFly 4 design #28

Merged
merged 1 commit into from Jan 22, 2020

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Jan 20, 2020

Important: I need help testing these changes as I am unclear on how to go about doing so.

The templates should render as seen at:

cc: @spadgett, @benjaminapetersen

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 20, 2020
@benjaminapetersen
Copy link

Screenshots maybe? This is tricky to review :)

@benjaminapetersen
Copy link

@stlaz fyi

@benjaminapetersen
Copy link

@rhamilto this should prob do the job:
https://gist.github.com/benjaminapetersen/3259fd041d47925f66a064a59311d443
It involves setting the authentication.operator to Unmanaged and then overriding the oauth-server image.

@benjaminapetersen
Copy link

@stlaz
Copy link
Member

stlaz commented Jan 21, 2020

/assign @stlaz

@rhamilto
Copy link
Member Author

/retest

@stlaz
Copy link
Member

stlaz commented Jan 22, 2020

/lgtm
appears to be working as expected

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit c682ac7 into openshift:master Jan 22, 2020
@rhamilto rhamilto deleted the templates-pf4 branch January 22, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants