[bug] m2m completes successfully when publishing to incorrect namespace

[afflom]

Version

Client Version: version.Info{Major:"", Minor:"", GitVersion:"v0.2.0-alpha.1-36-g7d88d4e", GitCommit:"7d88d4e8", GitTreeState:"clean", BuildDate:"2022-05-16T20:28:02Z", GoVersion:"go1.18", Compiler:"gc", Platform:"linux/amd64"}

What happened?

when publishing m2m differential synchronizations, if an incorrect namespace is targeted for publishing, oc-mirror does not produce a sequence error as expected.

What did you expect to happen?

differential syncs should error if published to a different registry namespace than previous syncs.

How to reproduce it (as minimally and precisely as possible)?

publish a to a mirror registry namespace and then use m2m to publish a diff to a different namespace.

[jpower432]

In this instance a new workspace would be created if the sequence number is not 1, there would be an error. for the disk to mirror workflow. So this should only happen in the instance where a imageset was published for the first time as a new workspace in one namespace and then subsequently in another.

For disk to mirror and mirror to mirror workflows, I would not like to add this constraint as publishing with different namespace is a tactic being used for image promotion.

[jpower432]

Discussed out of band. The solution would be to disallow the publishing of a differential imageset if there is no instance of metadata in the target namespace.