Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: block operator images #32

Merged
merged 1 commit into from
Aug 12, 2021
Merged

feat: block operator images #32

merged 1 commit into from
Aug 12, 2021

Conversation

jpower432
Copy link
Contributor

  • Added a IsBlocked check for the operator catalogs
  • Main caveat is that I need to edit a function that we had temporarily so I could have access to each image.

@jpower432 jpower432 linked an issue Aug 11, 2021 that may be closed by this pull request
Handle Blocked images #8
Closed
@jpower432
Copy link
Contributor Author

Closes issue #8. Blocked by PR #1.

@jpower432 jpower432 force-pushed the feat/block-operator-images branch 2 times, most recently from e54f65a to 99ed960 Compare August 12, 2021 18:57
@jpower432 jpower432 changed the title [WIP] Feat/block operator images feat: block operator images Aug 12, 2021
estroz
estroz suggested changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix, otherwise LGTM

data/imageset-config.yaml Outdated Show resolved Hide resolved
pkg/operator/operator.go Outdated Show resolved Hide resolved
@jpower432 jpower432 requested a review from estroz August 12, 2021 20:21
@jpower432 jpower432 merged commit 9ad2b24 into openshift:main Aug 12, 2021
@jpower432 jpower432 deleted the feat/block-operator-images branch September 1, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle Blocked images
2 participants
@jpower432 @estroz