[release-4.7] Bug 2039763: Remove `git://` from new-app tests #1024

openshift-cherrypick-robot · 2022-01-12T11:52:25Z

This is an automated cherry-pick of #1020

/assign adambkaplan

GitHub is removing support for the unsecured "git://" protocol when cloning source code [1]. This is being done in phases, with full removal happening on March 15, 2022. Some of the new-app unit tests connect to GitHub and attempt to clone source code - this updates the tests to use HTTPS instead of `git://`. [1] https://github.blog/2021-09-01-improving-git-protocol-security-github/

openshift-ci · 2022-01-12T11:52:37Z

@openshift-cherrypick-robot: Bugzilla bug 2039491 has been cloned as Bugzilla bug 2039763. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 2039763: Remove git:// from new-app tests

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-12T11:52:44Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039491 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
expected dependent Bugzilla bug 2039491 to target a release in 4.8.0, 4.8.z, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2022-01-12T11:58:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-01-12T14:35:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-12T16:32:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-01-12T18:21:10Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-01-13T01:00:35Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-13T01:00:38Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-14T01:01:09Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-14T01:01:13Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-15T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-15T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-16T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-16T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-17T01:01:09Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-17T01:01:13Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-18T01:01:10Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-12T01:00:57Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-13T01:00:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-13T01:00:28Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-14T01:00:29Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-14T01:00:32Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-15T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-15T01:01:11Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2022-02-15T20:55:08Z

Note that this PR needs to merge by March 15th, otherwise the impacted tests will fail.

openshift-bot · 2022-02-16T01:01:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-16T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-17T01:00:46Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-17T01:00:49Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-18T01:01:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-18T01:01:17Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-19T01:00:24Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-19T01:00:27Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-20T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-20T01:01:04Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-21T01:01:01Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-21T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is invalid:

expected dependent Bugzilla bug 2039762 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-22T01:02:06Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-22T01:02:14Z

@openshift-bot: This pull request references Bugzilla bug 2039763, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2039762 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2039762 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
bug has dependents

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kasturinarra · 2022-02-23T18:36:07Z

/label cherry-pick-approved

openshift-ci · 2022-02-23T18:37:08Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/oc#1024

Bugzilla bug 2039763 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-04-29T00:35:31Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-tools-container-v4.7.0-202304290014.p0.gc4ebc7a.assembly.stream for distgit ose-tools.
All builds following this will include this PR.

openshift-ci bot assigned adambkaplan Jan 12, 2022

openshift-cherrypick-robot mentioned this pull request Jan 12, 2022

Bug 2039491: Remove git:// from new-app tests #1020

Merged

openshift-ci bot changed the title ~~[release-4.7] Bug 2039491: Remove git:// from new-app tests~~ [release-4.7] Bug 2039763: Remove git:// from new-app tests Jan 12, 2022

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 12, 2022

openshift-ci bot requested review from smarterclayton and soltysh January 12, 2022 11:52

soltysh approved these changes Jan 12, 2022

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 12, 2022

openshift-ci bot assigned soltysh Jan 12, 2022

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 12, 2022

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 22, 2022

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 22, 2022

openshift-ci bot requested a review from zhouying7780 February 22, 2022 01:02

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 23, 2022

openshift-merge-robot merged commit c4ebc7a into openshift:release-4.7 Feb 23, 2022

[release-4.7] Bug 2039763: Remove git:// from new-app tests #1024

[release-4.7] Bug 2039763: Remove git:// from new-app tests #1024

Conversation

openshift-cherrypick-robot commented Jan 12, 2022

openshift-ci bot commented Jan 12, 2022

openshift-ci bot commented Jan 12, 2022

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jan 12, 2022

openshift-bot commented Jan 12, 2022

openshift-bot commented Jan 12, 2022

openshift-ci bot commented Jan 12, 2022

openshift-bot commented Jan 13, 2022

openshift-ci bot commented Jan 13, 2022

openshift-bot commented Jan 14, 2022

openshift-ci bot commented Jan 14, 2022

openshift-bot commented Jan 15, 2022

openshift-ci bot commented Jan 15, 2022

openshift-bot commented Jan 16, 2022

openshift-ci bot commented Jan 16, 2022

openshift-bot commented Jan 17, 2022

openshift-ci bot commented Jan 17, 2022

openshift-bot commented Jan 18, 2022

openshift-ci bot commented Feb 12, 2022

openshift-bot commented Feb 13, 2022

openshift-ci bot commented Feb 13, 2022

openshift-bot commented Feb 14, 2022

openshift-ci bot commented Feb 14, 2022

openshift-bot commented Feb 15, 2022

openshift-ci bot commented Feb 15, 2022

adambkaplan commented Feb 15, 2022

openshift-bot commented Feb 16, 2022

openshift-ci bot commented Feb 16, 2022

openshift-bot commented Feb 17, 2022

openshift-ci bot commented Feb 17, 2022

openshift-bot commented Feb 18, 2022

openshift-ci bot commented Feb 18, 2022

openshift-bot commented Feb 19, 2022

openshift-ci bot commented Feb 19, 2022

openshift-bot commented Feb 20, 2022

openshift-ci bot commented Feb 20, 2022

openshift-bot commented Feb 21, 2022

openshift-ci bot commented Feb 21, 2022

openshift-bot commented Feb 22, 2022

openshift-ci bot commented Feb 22, 2022

kasturinarra commented Feb 23, 2022

openshift-ci bot commented Feb 23, 2022

openshift-bot commented Apr 29, 2023

[release-4.7] Bug 2039763: Remove `git://` from new-app tests #1024

[release-4.7] Bug 2039763: Remove `git://` from new-app tests #1024