Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oc adm inspect command #107

Merged
merged 53 commits into from
Sep 27, 2019
Merged

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Sep 27, 2019

This is fixed version of #42.

Move inspect command from openshift-must-gather to oc adm.

/assign @sanchezl

juanvallejo and others added 30 commits September 26, 2019 15:51
Use a dynamic client to fetch namespace resources in order to serialize
them properly when storing them as files.
Adds a port-forwarder and a PortForwardURLGetter to replace the RemoteExecutor.
This will allow endpoint data retrieval from pods without needing to
generate a token, create a custom namespace or serviceaccount.
Previously, the portforwarder was not correctly patching a given
restclient config to use localhost:<local_port> as its host.
Prevents config.openshift.io and operator.openshift.io data
collection, unless explicitly dealing with a clusteroperator resource
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 27, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Sep 27, 2019

Self-tagging since this was already approved in the other instance.

@soltysh soltysh added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2d95fd6 into openshift:master Sep 27, 2019
@soltysh soltysh deleted the inspect branch September 27, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants