Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Migrate from deprecated ioutils to relevant libraries #1602

Merged

Conversation

ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Nov 24, 2023

This PR migrates from deprecated ioutil to all relevant suggested libraries.

There are a few ioutil usages left. Because ioutil.ReadDir and os.ReadDir return different objects and
to keep the simplicity of this PR, these will be handled in a followup PR.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@ardaguclu
Copy link
Member Author

@openshift-ci openshift-ci bot requested review from atiratree, ingvagabund and soltysh and removed request for adambkaplan and coreydaley November 24, 2023 10:59
@ardaguclu
Copy link
Member Author

Unrelated;

/test e2e-metal-ipi-ipv6

Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

@ardaguclu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-rpms-from-tar
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-builds
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-upgrade
  • /test images
  • /test rpm-build
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-aws-certrotation
  • /test e2e-metal-ipi-ovn-ipv6
  • /test security

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-oc-master-build-rpms-from-tar
  • pull-ci-openshift-oc-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-oc-master-e2e-aws-ovn
  • pull-ci-openshift-oc-master-e2e-aws-ovn-builds
  • pull-ci-openshift-oc-master-e2e-aws-ovn-serial
  • pull-ci-openshift-oc-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-oc-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-oc-master-images
  • pull-ci-openshift-oc-master-rpm-build
  • pull-ci-openshift-oc-master-security
  • pull-ci-openshift-oc-master-unit
  • pull-ci-openshift-oc-master-verify
  • pull-ci-openshift-oc-master-verify-deps

In response to this:

Unrelated;

/test e2e-metal-ipi-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

@ingvagabund
Copy link
Member

/lgtm

@ingvagabund
Copy link
Member

Let's wait after acknowledge-critical-fixes-only labeling gets turned off.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Member Author

/tide refresh

@ardaguclu
Copy link
Member Author

/label no-jira

Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@ardaguclu: The label(s) /label no-jira cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label no-jira

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu ardaguclu changed the title Migrate from deprecated ioutils to relevant libraries NO-JIRA: Migrate from deprecated ioutils to relevant libraries Nov 28, 2023
@openshift-ci-robot
Copy link

@ardaguclu: This pull request explicitly references no jira issue.

In response to this:

This PR migrates from deprecated ioutil to all relevant suggested libraries.

There are a few ioutil usages left. Because ioutil.ReadDir and os.ReadDir return different objects and
to keep the simplicity of this PR, these will be handled in a followup PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3b3f931 and 2 for PR HEAD 67813c2 in total

@ardaguclu
Copy link
Member Author

/retest-required

1 similar comment
@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f36933e and 1 for PR HEAD 67813c2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d76174f and 0 for PR HEAD 67813c2 in total

@openshift-ci-robot
Copy link

/hold

Revision 67813c2 was retested 3 times: holding

@ardaguclu
Copy link
Member Author

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 48834dc and 2 for PR HEAD 67813c2 in total

@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4b1a57e and 1 for PR HEAD 67813c2 in total

@ardaguclu
Copy link
Member Author

/retest

1 similar comment
@ardaguclu
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f2953f3 and 0 for PR HEAD 67813c2 in total

@openshift-ci-robot
Copy link

/hold

Revision 67813c2 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@ardaguclu
Copy link
Member Author

Just to see;
/retest

@ardaguclu
Copy link
Member Author

Opened this openshift/origin#28442 to see whether it works.

@ardaguclu
Copy link
Member Author

Opened this https://issues.redhat.com/browse/OCPBUGS-24569 to track the bug that aws-ovn-builds is perma-failing.

@ardaguclu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f2953f3 and 2 for PR HEAD 67813c2 in total

@ardaguclu
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

e2e-aws-ovn-builds failure should be fixed by openshift/origin#28471

@ardaguclu
Copy link
Member Author

The PR fixing the perma failing job has been merged;

/hold cancel
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
@ardaguclu
Copy link
Member Author

/retest

1 similar comment
@ardaguclu
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 36f5a45 and 2 for PR HEAD 67813c2 in total

@ardaguclu
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4c9da31 into openshift:master Dec 21, 2023
14 checks passed
@ardaguclu ardaguclu deleted the remove-deprecated-ioutil branch December 21, 2023 07:00
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202312210731.p0.g4c9da31.assembly.stream for distgit openshift-enterprise-cli.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants