New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Migrate from deprecated ioutils to relevant libraries #1602
NO-JIRA: Migrate from deprecated ioutils to relevant libraries #1602
Conversation
/uncc @adambkaplan @coreydaley |
Unrelated; /test e2e-metal-ipi-ipv6 |
@ardaguclu: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-metal-ipi-ovn-ipv6 |
/lgtm |
Let's wait after |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/tide refresh |
/label no-jira |
@ardaguclu: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ardaguclu: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
1 similar comment
/retest-required |
/hold Revision 67813c2 was retested 3 times: holding |
/hold cancel |
/retest-required |
/retest |
1 similar comment
/retest |
/hold Revision 67813c2 was retested 3 times: holding |
Just to see; |
Opened this openshift/origin#28442 to see whether it works. |
Opened this https://issues.redhat.com/browse/OCPBUGS-24569 to track the bug that aws-ovn-builds is perma-failing. |
/hold cancel |
/hold |
/retest-required |
e2e-aws-ovn-builds failure should be fixed by openshift/origin#28471 |
The PR fixing the perma failing job has been merged; /hold cancel |
/retest |
1 similar comment
/retest |
/retest |
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202312210731.p0.g4c9da31.assembly.stream for distgit openshift-enterprise-cli. |
This PR migrates from deprecated
ioutil
to all relevant suggested libraries.There are a few ioutil usages left. Because
ioutil.ReadDir
andos.ReadDir
return different objects andto keep the simplicity of this PR, these will be handled in a followup PR.