Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1779331: Fix a number of issues around debugging daemonset pods and init containers #166

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Bug 1779331: Fix a number of issues around debugging daemonset pods and init containers #166

merged 5 commits into from
Dec 3, 2019

Commits on Nov 17, 2019

  1. debug: Allow the object to be targeted at another namespace 

    When using `oc debug istag/foo:bar` it is not uncommon to want to
create the debug pod in another namespace. Make that possible by
adding `--to-namespace` which overrides the pod namespace.
    @smarterclayton
    smarterclayton committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    a8eb62c View commit details
    Browse the repository at this point in the history

  2. debug: Clear initContainers when --one-container 

    The implication of --one-container is that we only want a single
container.
    @smarterclayton
    smarterclayton committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    e78b64c View commit details
    Browse the repository at this point in the history

  3. debug: Print init containers in the list of suggested container names 

    We only printed the regular container names.
    @smarterclayton
    smarterclayton committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    2aa5641 View commit details
    Browse the repository at this point in the history

  4. debug: When debugging an init container, don't clear it immediately 

    If a user specifies an init container, we have to preserve it even
if `--keep-init-containers=false` is set. In that case, we strip
all other init containers.
    @smarterclayton
    smarterclayton committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    175c747 View commit details
    Browse the repository at this point in the history

  5. debug: Clear host ports when debugging a pod 

    If there is a host port set, clear it. If this is a host network pod,
clear all ports. This allows us to debug a pod on the same node for
daemonsets that declare host network or host pods.
    @smarterclayton
    smarterclayton committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    9a9ced5 View commit details
    Browse the repository at this point in the history