OCPBUGS-31484: Remove some of newapp unit tests relying on external deprecated images

[ardaguclu]

We invested a good amount of effort to maintain the unit tests for oc newapp (aka TestNewApp*) by migrating to the equivalents that are alive, when the images they use were removed. However, after all the images have been removed from quay.io/centos7 (e.g. quay.io/centos7/ruby-27-centos7, quay.io/centos7/redis-5-centos7), it seems that there is nowhere we can go.

Creating new images and maintaining them separately just for these tests would be an option but it doesn't seems to be the reasonable one. That's why, this PR removes the tests depending on these images. Because we don't/won't make changes to this command (oc newapp).

[openshift-ci-robot]

@ardaguclu: This pull request references Jira Issue OCPBUGS-31484, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ardaguclu]

/jira refresh

[openshift-ci-robot]

@ardaguclu: This pull request references Jira Issue OCPBUGS-31484, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (aos-workloads-staff@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ardaguclu: This pull request references Jira Issue OCPBUGS-31484, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (aos-workloads-staff@redhat.com), skipping review request.

In response to this:

We invested a good amount of effort to maintain the unit tests for oc newapp (aka TestNewApp*) by migrating to the equivalents that are alive, when the images they use were removed. However, after all the images have been removed from quay.io/centos7 (e.g. quay.io/centos7/ruby-27-centos7, quay.io/centos7/redis-5-centos7), it seems that there is nowhere we can go.

Creating new images and maintaining them separately just for these tests would be an option but it doesn't seems to be the reasonable one. That's why, this PR removes the tests depending on these images.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ardaguclu]

@ingvagabund could you PTAL?. Thanks.

[ardaguclu]

This PR is blocked by openshift/origin#28675

[soltysh]

/lgtm
/hold
for openshift/origin#28675

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/helpers/newapp/OWNERS [ardaguclu,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ardaguclu]

/retest
/hold cancel

[ardaguclu]

/retest

[openshift-ci]

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@ardaguclu: Jira Issue OCPBUGS-31484: All pull requests linked via external trackers have merged:

• openshift/oc#1717
• openshift/origin#28675

Jira Issue OCPBUGS-31484 has been moved to the MODIFIED state.

In response to this:

We invested a good amount of effort to maintain the unit tests for oc newapp (aka TestNewApp*) by migrating to the equivalents that are alive, when the images they use were removed. However, after all the images have been removed from quay.io/centos7 (e.g. quay.io/centos7/ruby-27-centos7, quay.io/centos7/redis-5-centos7), it seems that there is nowhere we can go.

Creating new images and maintaining them separately just for these tests would be an option but it doesn't seems to be the reasonable one. That's why, this PR removes the tests depending on these images. Because we don't/won't make changes to this command (oc newapp).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202403281444.p0.gec6e928.assembly.stream.el8 for distgit openshift-enterprise-cli.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-03-28-223620

[ardaguclu]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@ardaguclu: #1717 failed to apply on top of branch "release-4.15":

Applying: Remove some of newapp unit tests relying on external deprecated images
Using index info to reconstruct a base tree...
M	pkg/helpers/newapp/newapptest/newapp_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/helpers/newapp/newapptest/newapp_test.go
CONFLICT (content): Merge conflict in pkg/helpers/newapp/newapptest/newapp_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove some of newapp unit tests relying on external deprecated images
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.