Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31484: Use centos7 tag instead of latest for cmd images tests #28675

Merged
merged 1 commit into from Mar 28, 2024

Conversation

ardaguclu
Copy link
Member

Images' latest tag and auto built mechanisms have been permanently disabled in quay.io/centos7 repository.
This PR modifies these images to use centos7 tag instead of latest. So that cmd/images.sh tests will continue passing.

But there is no indication whether, at some point in the future, these images or this tag will be removed also or not. I try to remove unit tests entirely to overcome this issue openshift/oc#1717 but maybe for e2e tests, we can give one more try to continue with centos7 tag, until it is removed.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 28, 2024
@openshift-ci-robot
Copy link

@ardaguclu: This pull request references Jira Issue OCPBUGS-31484, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (aos-workloads-staff@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Images' latest tag and auto built mechanisms have been permanently disabled in quay.io/centos7 repository.
This PR modifies these images to use centos7 tag instead of latest. So that cmd/images.sh tests will continue passing.

But there is no indication whether, at some point in the future, these images or this tag will be removed also or not. I try to remove unit tests entirely to overcome this issue openshift/oc#1717 but maybe for e2e tests, we can give one more try to continue with centos7 tag, until it is removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ardaguclu, soltysh
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member

soltysh commented Mar 28, 2024

/label approve

Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@soltysh: The label(s) /label approve cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member Author

@bparees could you please take a look at this?. Thanks.

Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 3d307aa link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade 3d307aa link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 3d307aa link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn 3d307aa link false /test e2e-metal-ipi-sdn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Member

soltysh commented Mar 28, 2024

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8b3dee6 into openshift:master Mar 28, 2024
19 of 23 checks passed
@openshift-ci-robot
Copy link

@ardaguclu: Jira Issue OCPBUGS-31484: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-31484 has not been moved to the MODIFIED state.

In response to this:

Images' latest tag and auto built mechanisms have been permanently disabled in quay.io/centos7 repository.
This PR modifies these images to use centos7 tag instead of latest. So that cmd/images.sh tests will continue passing.

But there is no indication whether, at some point in the future, these images or this tag will be removed also or not. I try to remove unit tests entirely to overcome this issue openshift/oc#1717 but maybe for e2e tests, we can give one more try to continue with centos7 tag, until it is removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu ardaguclu deleted the ocpbugs-31484 branch March 28, 2024 11:15
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403281444.p0.g8b3dee6.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-03-28-223620

@sanchezl
Copy link
Contributor

sanchezl commented Apr 3, 2024

This should be back-ported.

@ardaguclu
Copy link
Member Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@ardaguclu: new pull request created: #28688

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants