New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build on go 1.13 #194
Fix build on go 1.13 #194
Conversation
Addressing: $ go version go version go1.13 linux/amd64 $ make build go: github.com/openshift/api@v0.0.0-0.20191112184635-86def77f6f: invalid pseudo-version: revision is shorter than canonical (86def77f6f90) make: Nothing to be done for 'build'. When extracting a module from a version control system, the go command now performs additional validation on the requested version string. More information can be found at https://tip.golang.org/doc/go1.13#version-validation
Hi @isimluk. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: isimluk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
i propose #206 as better fix :-) |
This is already fixed. |
@soltysh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@isimluk: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Addressing:
When extracting a module from a version control system, the go command now performs additional validation on the requested version string. More information can be found at https://tip.golang.org/doc/go1.13#version-validation