Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on go 1.13 #194

Closed
wants to merge 1 commit into from
Closed

Conversation

isimluk
Copy link

@isimluk isimluk commented Dec 2, 2019

Addressing:

$ go version
go version go1.13 linux/amd64
$ make build
go: github.com/openshift/api@v0.0.0-0.20191112184635-86def77f6f: invalid pseudo-version: revision is shorter than canonical (86def77f6f90)
make: Nothing to be done for 'build'.

When extracting a module from a version control system, the go command now performs additional validation on the requested version string. More information can be found at https://tip.golang.org/doc/go1.13#version-validation

Addressing:
$ go version
go version go1.13 linux/amd64
$ make build
go: github.com/openshift/api@v0.0.0-0.20191112184635-86def77f6f: invalid pseudo-version: revision is shorter than canonical (86def77f6f90)
make: Nothing to be done for 'build'.

When extracting a module from a version control system, the go command now
performs additional validation on the requested version string. More information
can be found at https://tip.golang.org/doc/go1.13#version-validation
@openshift-ci-robot
Copy link

Hi @isimluk. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: isimluk
To complete the pull request process, please assign deads2k
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik
Copy link
Member

mfojtik commented Dec 10, 2019

i propose #206 as better fix :-)

@soltysh
Copy link
Member

soltysh commented Dec 20, 2019

This is already fixed.
/close

@openshift-ci-robot
Copy link

@soltysh: Closed this PR.

In response to this:

This is already fixed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2019
@openshift-ci-robot
Copy link

@isimluk: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants