Bug 1788194: allow --config and --kubeconfig #246
Conversation
openshift-ci-robot
added
the
size/L
| pathOptions := &kclientcmd.PathOptions{ | ||
| GlobalFile: kclientcmd.RecommendedHomeFile, | ||
| EnvVar: kclientcmd.RecommendedConfigPathEnvVar, | ||
| ExplicitFileFlag: genericclioptions.OpenShiftKubeConfigFlagName, |
There was a problem hiding this comment.
@sallyom this was the place that was panicing for you, b/c it tried to have --config registered twice.
There was a problem hiding this comment.
oh, I see what I was doing wrong now. I was duplicating the if !openshiftpatch.IsOC in this file, so not fixing the panic.
openshift-ci-robot
added
the
approved
soltysh
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@soltysh: This pull request references Bugzilla bug 1788194, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@soltysh: All pull requests linked via external trackers have merged. Bugzilla bug 1788194 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @sallyom