Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1792330: pods that are no longer running can still have logs #262

Merged
merged 1 commit into from Jan 21, 2020
Merged

Bug 1792330: pods that are no longer running can still have logs #262

merged 1 commit into from Jan 21, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 17, 2020

When pods are stopped or crashlooped, they can still have logs. We want to collect those logs.

/assign @soltysh

You'll need to pick this one too.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Jan 17, 2020

/cherrypick release-4.3

@openshift-cherrypick-robot
Copy link

@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020
@deads2k deads2k changed the title pods that are no longer running can still have logs Bug 1792330: pods that are no longer running can still have logs Jan 17, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 17, 2020
@openshift-ci-robot
Copy link

@deads2k: This pull request references Bugzilla bug 1792330, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1792330: pods that are no longer running can still have logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor Author

deads2k commented Jan 18, 2020

/retest

soltysh
soltysh approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@soltysh
Copy link
Member

soltysh commented Jan 20, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh soltysh mentioned this pull request Jan 20, 2020
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ashishranjan738
Copy link
Contributor

I guess this statement

oc/pkg/cli/admin/inspect/pod.go

Line 20 in 8145eb2

if pod.Status.Phase != corev1.PodRunning {
also needs to be removed @soltysh @deads2k

@ashishranjan738
Copy link
Contributor

I guess this statement

oc/pkg/cli/admin/inspect/pod.go

Line 20 in 8145eb2

if pod.Status.Phase != corev1.PodRunning {

also needs to be removed @soltysh @deads2k

there can be some pods in Completed state, and they can contain logs.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Jan 21, 2020

updated

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2020
soltysh
soltysh approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7efa52b into openshift:master Jan 21, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 21, 2020
Merged
@openshift-cherrypick-robot
Copy link

@deads2k: new pull request created: #263

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@deads2k @openshift-cherrypick-robot @openshift-ci-robot @soltysh @openshift-bot @ashishranjan738 @openshift-merge-robot