Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1790785: bump(operator-framework/operator-registry) #329

Conversation

Bowenislandsong
Copy link

Bumps operator-registry, which fixes two BZs:

https://bugzilla.redhat.com/show_bug.cgi?id=1790785
https://bugzilla.redhat.com/show_bug.cgi?id=1772942 (already fixed in master, but this needs to propagate to 4.3)

This commit supersedes #316.

Bumps operator-registry, which fixes two BZs:

https://bugzilla.redhat.com/show_bug.cgi?id=1790785
https://bugzilla.redhat.com/show_bug.cgi?id=1772942 (already fixed in master, but this needs to propagate to 4.3)

This commit supersedes openshift#316.
@openshift-ci-robot
Copy link

@Bowenislandsong: This pull request references Bugzilla bug 1790785, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1790785: bump(operator-framework/operator-registry)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 27, 2020
@Bowenislandsong
Copy link
Author

/cc @ecordell @soltysh

@@ -55,7 +55,7 @@ require (
k8s.io/apimachinery v0.17.1
k8s.io/apiserver v0.17.1
k8s.io/cli-runtime v0.17.0
k8s.io/client-go v0.17.1
k8s.io/client-go v8.0.0+incompatible
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do want to point out that this is replaced later at

oc/go.mod

Line 77 in f447321

k8s.io/client-go => github.com/openshift/kubernetes-client-go v0.0.0-20191211181558-5dcabadb2b45
. Therefore it does not matter that is it changed at this stage.

Copy link
Contributor

@tnozicka tnozicka Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it matters for transitive dependencies (the repo building on oc will get this)

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bowenislandsong, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@Bowenislandsong
Copy link
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants