set volume does not work with --local
#332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A local option should exit, not continue. Without the exit we double print the object we are modifying instead of simply exiting.
When `--local` is set `info.Mapping` is nil, which causes panics in the command. Use the external patches method and remove the old helper that no longer works, and fix places in the error path where we assume mapping is present. This was missed when the upstream changed.
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
|
/retest |
|
/assign @soltysh |
soltysh
approved these changes
Mar 17, 2020
| @@ -494,6 +494,7 @@ func (o *VolumeOptions) RunVolume() error { | |||
| return err | |||
| } | |||
| } | |||
| return nil | |||
There was a problem hiding this comment.
We should drop similar lines few lines below, I'll handle that in a followup.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--localis setinfo.Mappingis nil, which causes panics in thecommand. Use the external patches method and remove the old helper that no
longer works, and fix places in the error path where we assume mapping is
present. This was missed when the upstream changed.
Also fix bug where --local causes the object to be printed twice.
Needs a test/cmd test