oc debug: add help for --to-namespace #346
Conversation
openshift-ci-robot
added
the
size/XS
| # Note: Not all resources can be debugged using --to-namespace without modification. For example, | ||
| # volumes and serviceaccounts are namespace-dependent. Add '-o yaml' to output the debug pod definition | ||
| # to disk. If necessary, edit the definition then run 'oc debug -f -' or run without --to-namespace. | ||
| %[1]s node/node-m-0.openshift.example.internal --to-namespace testns`) | ||
| ) |
There was a problem hiding this comment.
might be a bit wordy. from what I see, --to-namespace is the only default flag that causes issues (that a user might stumble across). --node-name causes issues if you try to run a node-role.kubernetes.io/master pod on a worker node 🤷♀️
pkg/cli/debug/debug.go
Outdated
| # Note: Not all resources can be debugged using --to-namespace without modification. For example, | ||
| # volumes and serviceaccounts are namespace-dependent. Add '-o yaml' to output the debug pod definition | ||
| # to disk. If necessary, edit the definition then run 'oc debug -f -' or run without --to-namespace. | ||
| %[1]s node/node-m-0.openshift.example.internal --to-namespace testns`) |
There was a problem hiding this comment.
User simpler example %[1]s mypod-9xbc --to-namespace testns, debugging node is a heavy gun 😉
There was a problem hiding this comment.
ok, i updated to use pod instead.
openshift-ci-robot
added
the
approved
sallyom
force-pushed
the
add-help-debug-pod
branch
from
e74ae67
to
ecb3f2f
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
/cc @soltysh
/cc @smarterclayton