Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: Correctly default the tools image now that it is on the cluster #368

Merged

Conversation

smarterclayton
Copy link
Contributor

Now debug uses openshift/tools:latest which is provided by the payload.

Now debug uses openshift/tools:latest which is provided by the payload.
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2020
@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2020
@smarterclayton
Copy link
Contributor Author

Trivial fix and I am eager to begin testing tools...

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4e8a3bc into openshift:master Apr 4, 2020
@zhengbin78
Copy link

zhengbin78 commented Apr 9, 2020

This bug exists in versions 4.4 and 4.3. Can you merge this to versions 4.3 and 4.4 as soon as possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants