Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1821648: Zeroing BearerTokenFile for prune #376

Merged
merged 1 commit into from Apr 9, 2020
Merged

Bug 1821648: Zeroing BearerTokenFile for prune #376

merged 1 commit into from Apr 9, 2020

Conversation

ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Apr 7, 2020 •
edited

Kubernetes client-go requires only one authentication method to be present
therefore this patch zeroes the content of BearerTokenFile as basic auth
is used during prune.

In a nutshell: or we use token based authentication or basic auth, never
both at the same time.

This is a version of #257

@openshift-ci-robot
Copy link

@ricardomaraschini: This pull request references Bugzilla bug 1821648, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1790978 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1790978 targets the "4.4.0" release, matching the expected (4.4.0) release
  • bug has dependents

In response to this:

Bug 1821648: Zeroing BearerTokenFile for prune

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 7, 2020
@ricardomaraschini
Zeroing BearerTokenFile for prune
62e0a14 
Kubernetes client-go requires only one authentication method to be present
therefore this patch zeroes the content of BearerTokenFile as basic auth
is used during prune.

In a nutshell: or we use token based authentication or basic auth, never
both at the same time.

This is a cherrypick of 966f1bb
@openshift-ci-robot
Copy link

@ricardomaraschini: This pull request references Bugzilla bug 1821648, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1790978 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1790978 targets the "4.4.0" release, matching the expected (4.4.0) release
  • bug has dependents

In response to this:

Bug 1821648: Zeroing BearerTokenFile for prune

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini
Copy link
Contributor Author

/test unit

@ricardomaraschini
Copy link
Contributor Author

/retest

soltysh
soltysh approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh
Copy link
Member

soltysh commented Apr 7, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ricardomaraschini, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4fb2d4d into openshift:release-4.3 Apr 9, 2020
@openshift-ci-robot
Copy link

@ricardomaraschini: All pull requests linked via external trackers have merged: openshift/oc#376. Bugzilla bug 1821648 has been moved to the MODIFIED state.

In response to this:

Bug 1821648: Zeroing BearerTokenFile for prune

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ricardomaraschini @openshift-ci-robot @soltysh @derekwaynecarr @openshift-merge-robot