New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1826676: oc status: check if the current project exists before printing status #413
bug 1826676: oc status: check if the current project exists before printing status #413
Conversation
@ingvagabund: This pull request references Bugzilla bug 1826676, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ingvagabund: An error was encountered searching for bug 1826676 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Fix the nit and it's good to go
It can happen a project is no longer available when running the status. Right now, oc status considers "namespaces XXX not found" error message as valid and keeps querying for services, deployment, etc. over on-existing namespace.
94005c8
to
c00ba05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ingvagabund: All pull requests linked via external trackers have merged: openshift/oc#413. Bugzilla bug 1826676 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It can happen a project is no longer available when running the status.
Right now, oc status considers "namespaces XXX not found" error message
as valid and keeps querying for services, deployment, etc. over
on-existing namespace.
New output for non-existing namespaces: