Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1826676: oc status: check if the current project exists before printing status #413

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented May 11, 2020

It can happen a project is no longer available when running the status.
Right now, oc status considers "namespaces XXX not found" error message
as valid and keeps querying for services, deployment, etc. over
on-existing namespace.

New output for non-existing namespaces:

$ oc status
error: the project "jenkins-csb-skynet" specified in your config does not exist.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 11, 2020
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Bugzilla bug 1826676, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

bug 1826676: oc status: check if the current project exists before printing status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@ingvagabund: An error was encountered searching for bug 1826676 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1826676?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

bug 1826676: oc status: check if the current project exists before printing status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Fix the nit and it's good to go

pkg/cli/status/status.go Outdated Show resolved Hide resolved
pkg/cli/status/status.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
It can happen a project is no longer available when running the status.
Right now, oc status considers "namespaces XXX not found" error message
as valid and keeps querying for services, deployment, etc. over
on-existing namespace.
@ingvagabund ingvagabund force-pushed the oc-status-check-if-ns-exists branch from 94005c8 to c00ba05 Compare May 12, 2020 10:54
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a74cb6e into openshift:master May 13, 2020
@openshift-ci-robot
Copy link

@ingvagabund: All pull requests linked via external trackers have merged: openshift/oc#413. Bugzilla bug 1826676 has been moved to the MODIFIED state.

In response to this:

bug 1826676: oc status: check if the current project exists before printing status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants