Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1835997: create route reencrypt: Improve --dest-ca-cert help #421

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented May 14, 2020

  • pkg/cli/create/routereenecrypt.go (reencryptRouteLong): Indicate that --dest-ca-cert is optional and that the destination CA certificate defaults to the service CA.
    (reencryptRouteExample): Omit --dest-ca-cert from one example.
    (NewCmdCreateReencryptRoute): Omit --dest-ca-cert from the synopsis as the flag is optional and is already mentioned in the description and flags sections. Document the default behavior when --dest-ca-cert is omitted.

@openshift/openshift-team-network-edge

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label May 14, 2020
@openshift-ci-robot
Copy link

@Miciah: This pull request references Bugzilla bug 1835997, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1835997: create route reencrypt: Improve --dest-ca-cert help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 14, 2020
@Miciah
Copy link
Contributor Author

Miciah commented May 14, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 14, 2020
@openshift-ci-robot
Copy link

@Miciah: This pull request references Bugzilla bug 1835997, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 14, 2020
This commit fixes bug 1835997.

https://bugzilla.redhat.com/show_bug.cgi?id=1835997

* pkg/cli/create/routereenecrypt.go (reencryptRouteLong): Indicate that
--dest-ca-cert is optional and that the destination CA certificate defaults
to the service CA.
(reencryptRouteExample): Omit --dest-ca-cert from one example.
(NewCmdCreateReencryptRoute): Omit --dest-ca-cert from the synopsis as the
flag is optional and is already mentioned in the description and flags
sections.  Document the default behavior when --dest-ca-cert is omitted.
@Miciah Miciah force-pushed the BZ1835997-create-route-reencrypt-improve--dest-ca-cert-help branch from 3f9ac6a to 9f96dd4 Compare May 14, 2020 21:18
@openshift-ci-robot
Copy link

@Miciah: This pull request references Bugzilla bug 1835997, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1835997: create route reencrypt: Improve --dest-ca-cert help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit e5110c7 into openshift:master May 15, 2020
@openshift-ci-robot
Copy link

@Miciah: All pull requests linked via external trackers have merged: openshift/oc#421. Bugzilla bug 1835997 has been moved to the MODIFIED state.

In response to this:

Bug 1835997: create route reencrypt: Improve --dest-ca-cert help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants