New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1835997: create route reencrypt: Improve --dest-ca-cert help #421
Bug 1835997: create route reencrypt: Improve --dest-ca-cert help #421
Conversation
@Miciah: This pull request references Bugzilla bug 1835997, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@Miciah: This pull request references Bugzilla bug 1835997, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit fixes bug 1835997. https://bugzilla.redhat.com/show_bug.cgi?id=1835997 * pkg/cli/create/routereenecrypt.go (reencryptRouteLong): Indicate that --dest-ca-cert is optional and that the destination CA certificate defaults to the service CA. (reencryptRouteExample): Omit --dest-ca-cert from one example. (NewCmdCreateReencryptRoute): Omit --dest-ca-cert from the synopsis as the flag is optional and is already mentioned in the description and flags sections. Document the default behavior when --dest-ca-cert is omitted.
3f9ac6a
to
9f96dd4
Compare
@Miciah: This pull request references Bugzilla bug 1835997, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Miciah: All pull requests linked via external trackers have merged: openshift/oc#421. Bugzilla bug 1835997 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/cli/create/routereenecrypt.go
(reencryptRouteLong
): Indicate that--dest-ca-cert
is optional and that the destination CA certificate defaults to the service CA.(
reencryptRouteExample
): Omit--dest-ca-cert
from one example.(
NewCmdCreateReencryptRoute
): Omit--dest-ca-cert
from the synopsis as the flag is optional and is already mentioned in the description and flags sections. Document the default behavior when--dest-ca-cert
is omitted.@openshift/openshift-team-network-edge