Bug 1774616: Update BuildLogOptions

[coreydaley]

Adds InsecureSkipTLSVerifyBackend to BuildLogOptions

[coreydaley]

/assign @adambkaplan @bparees

[bparees]

/lgtm

[adambkaplan]

@coreydaley please clean up this PR such that vendor changes only appear in a bump(xx) commit.

[openshift-ci-robot]

@coreydaley: This pull request references Bugzilla bug 1774616, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1774616: Update BuildLogOptions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coreydaley]

@coreydaley please clean up this PR such that vendor changes only appear in a bump(xx) commit.

I think they already are cleaned up?

[bparees]

vendor update commits should be titled bump(*) (or whatever example you can find in the commit history)

[coreydaley]

/assign @deads2k

[coreydaley]

/retest

[coreydaley]

@bparees can you re-lgtm me? I updated the commit message

[bparees]

it's bump(*).

you may have been only wanting to pick up openshift/api, but as you can see you also picked up a k8s api bump here.

[coreydaley]

@bparees fixed.

[bparees]

/lgtm

[bparees]

/lgtm

[coreydaley]

/retest

[deads2k]

/approve

/hold for @bparees to decide if he needs it for 4.5. We did this for pod logs to solve a rebootstrapping debugging scenario when kubelets running static pods cannot start. Builds don't require that.

[bparees]

/hold for @bparees to decide if he needs it for 4.5. We did this for pod logs to solve a rebootstrapping debugging scenario when kubelets running static pods cannot start. Builds don't require that.

definitely not a blocker for 4.5, so i'm going to defer to @soltysh as the defacto owner of the binary as to whether he's ok taking on the (low, imho) risk of including this change in 4.5.

[coreydaley]

/assign @soltysh

[soltysh]

This lgtm, but given we're two days away from final freeze, I'd advise this to hold for 4.6, for now.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, coreydaley, deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coreydaley]

@soltysh I think we should be able to merge this since 4.6 is open now.

[soltysh]

/hold cancel

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@coreydaley: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

• openshift/openshift-apiserver#110 is open
  Bugzilla bug 1774616 has been moved to the MODIFIED state.

In response to this:

Bug 1774616: Update BuildLogOptions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.