Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom printing with built-in printing in obseve commad #475

Merged
merged 3 commits into from Jul 14, 2020
Merged

Replace custom printing with built-in printing in obseve commad #475

merged 3 commits into from Jul 14, 2020

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Jun 23, 2020

/assing @sallyom

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@soltysh
Copy link
Member Author

soltysh commented Jul 13, 2020

/retest

@soltysh soltysh mentioned this pull request Jul 14, 2020
Merged
@soltysh
Copy link
Member Author

soltysh commented Jul 14, 2020

This is waiting for openshift/origin#25278
/assign @sallyom

@sallyom
Copy link
Contributor

sallyom commented Jul 14, 2020

/retest

@sallyom
Copy link
Contributor

sallyom commented Jul 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0f59da2 into openshift:master Jul 14, 2020
@soltysh soltysh deleted the clean_observe branch July 15, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@sallyom sallyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soltysh @sallyom @openshift-ci-robot @openshift-merge-robot