Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump(k8s.io/kubectl) for CSR fix #501

Merged
merged 1 commit into from Jul 22, 2020
Merged

bump(k8s.io/kubectl) for CSR fix #501

merged 1 commit into from Jul 22, 2020

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Jul 22, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@soltysh soltysh mentioned this pull request Jul 22, 2020
Closed
sttts
sttts reviewed Jul 22, 2020
View reviewed changes
go.mod
k8s.io/kubelet => k8s.io/kubelet v0.18.2
k8s.io/kubernetes => github.com/openshift/kubernetes v1.17.0-alpha.0.0.20200427141011-f0879866c662
k8s.io/kubernetes => github.com/openshift/kubernetes v1.19.0-alpha.0.0.20200427141011-f0879866c662
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.19?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like a follout from our recent switch to build hyperkube from o/k. The commit is the same though, if you look.

@sttts
Copy link
Contributor

sttts commented Jul 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member Author

soltysh commented Jul 22, 2020

/retest

@soltysh
Copy link
Member Author

soltysh commented Jul 22, 2020

/override ci/prow/e2e-cmd

@openshift-ci-robot
Copy link

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-cmd

In response to this:

/override ci/prow/e2e-cmd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 35f731d into openshift:master Jul 22, 2020
@soltysh soltysh deleted the v1beta1-csrs branch July 22, 2020 12:07
@wking wking mentioned this pull request Jul 22, 2020
Closed
@marun marun mentioned this pull request Jul 28, 2020
Merged
@davidspek davidspek mentioned this pull request Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soltysh @sttts @openshift-ci-robot @openshift-merge-robot