Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1866876: Signature verify error msgs to klog.V(4) rather than klog.Infof #526

Merged
merged 1 commit into from Aug 20, 2020
Merged

Bug 1866876: Signature verify error msgs to klog.V(4) rather than klog.Infof #526

merged 1 commit into from Aug 20, 2020

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Aug 20, 2020

I am not able to reproduce the info messages reported in the bug. I do see the messages are double printed, though. There might be a good reason why these are both printing klog.Infof and klog.V(4)?

/assign @soltysh
/cc @smarterclayton

@openshift-ci-robot
Copy link

@sallyom: Bugzilla bug 1866876 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

Bug 1866876: Signature verify error msgs to klog.V(4) rather than klog.Infof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2020
@soltysh
Copy link
Member

soltysh commented Aug 20, 2020

I'm manually applying valid bug label, since the bot can't access private bugs.

@soltysh soltysh added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit ea0d540 into openshift:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sallyom @openshift-ci-robot @soltysh @openshift-merge-robot