Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1872519: Allow prune to move on with Removed registry #532

Merged
merged 2 commits into from
Sep 3, 2020
Merged

[release-4.5] Bug 1872519: Allow prune to move on with Removed registry #532

merged 2 commits into from
Sep 3, 2020

Commits on Aug 26, 2020

  1. Allow prune to move on with Removed registry 

    Pruner attempts to derive internal image registry host from the last
unmanaged image or from the last image stream created. In some cases
OpenShift may not contain any of those (for instance in a fresh install
with Removed registry), this makes pruner to fail even with the flag
--prune-registry set to false.

This commit allows the pruner job to move on with the --prune-registry
flag set to false even when we can't derive the internal registry host.
    @ricardomaraschini
    ricardomaraschini authored and openshift-cherrypick-robot committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    3117227 View commit details
    Browse the repository at this point in the history

  2. Adding test cases for prune without images 

    When attempting to prune images but there is no images on the system we
need to succeed, except if we require the prune to also prune the
registry. On this case, as there is no image from where we can determine
the image registry host, we should fail.
    @ricardomaraschini
    ricardomaraschini authored and openshift-cherrypick-robot committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    d2030a8 View commit details
    Browse the repository at this point in the history