Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1872519: Allow prune to move on with Removed registry #532

Merged
merged 2 commits into from Sep 3, 2020
Merged

[release-4.5] Bug 1872519: Allow prune to move on with Removed registry #532

merged 2 commits into from Sep 3, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #520

/assign dmage

@ricardomaraschini
Allow prune to move on with Removed registry
3117227 
Pruner attempts to derive internal image registry host from the last
unmanaged image or from the last image stream created. In some cases
OpenShift may not contain any of those (for instance in a fresh install
with Removed registry), this makes pruner to fail even with the flag
--prune-registry set to false.

This commit allows the pruner job to move on with the --prune-registry
flag set to false even when we can't derive the internal registry host.
@ricardomaraschini
Adding test cases for prune without images
d2030a8 
When attempting to prune images but there is no images on the system we
need to succeed, except if we require the prune to also prune the
registry. On this case, as there is no image from where we can determine
the image registry host, we should fail.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 26, 2020
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1867792 has been cloned as Bugzilla bug 1872519. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1872519: Allow prune to move on with Removed registry

In response to this:

[release-4.5] Bug 1867792: Allow prune to move on with Removed registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1867792: Allow prune to move on with Removed registry [release-4.5] Bug 1872519: Allow prune to move on with Removed registry Aug 26, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 26, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1872519, which is invalid:

  • expected dependent Bugzilla bug 1867792 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.5] Bug 1872519: Allow prune to move on with Removed registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini
Copy link
Contributor

/retest

@dmage
Copy link
Member

dmage commented Aug 28, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@dmage: This pull request references Bugzilla bug 1872519, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1867792 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1867792 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 28, 2020
@dmage
Copy link
Member

dmage commented Aug 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@dmage
Copy link
Member

dmage commented Aug 28, 2020

/assign @soltysh

soltysh
soltysh approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2020
@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 3, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e40bd2d into openshift:release-4.5 Sep 3, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1872519 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1872519: Allow prune to move on with Removed registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@dmage dmage

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @ricardomaraschini @dmage @openshift-bot @soltysh @derekwaynecarr @openshift-merge-robot