Bug 1874056: Clean up and modify to use library-go verify package #535

jottofar · 2020-08-26T19:50:42Z

Modify to use proper k8s encoding/decoding and other minor clean up. Reference open comments from #343. Use library-go verify package which was created since both CVO and the oc client use them.

jottofar · 2020-08-26T20:27:31Z

/test unit

jottofar · 2020-08-31T14:11:49Z

/retest

jottofar · 2020-09-09T18:01:39Z

/retest

damemi · 2020-09-09T19:37:38Z

/retest

jottofar · 2020-09-09T21:32:54Z

/retest

jottofar · 2020-09-10T12:51:25Z

/hold
for more testing

jottofar · 2020-09-10T12:55:46Z

/test e2e-cmd

damemi · 2020-09-10T13:22:26Z

@soltysh these failures look like infra, not related to these changes right?

looks like timeouts:

I0909 22:43:16.785717     401 helpers.go:234] Connection error: Get https://api.ci-op-mlhn684d-d5f1e.origin-ci-int-gce.dev.openshift.com:6443/api/v1/namespaces/cmd-services/services/mynodeport: dial tcp 10.0.0.3:6443: i/o timeout
F0909 22:43:16.785742     401 helpers.go:115] Unable to connect to the server: dial tcp 10.0.0.3:6443: i/o timeout
goroutine 1 [running]:
k8s.io/klog/v2.stacks(0xc000010001, 0xc0007d2000, 0x73, 0x1cc)
	/go/src/github.com/openshift/oc/vendor/k8s.io/klog/v2/klog.go:996 +0xb8
k8s.io/klog/v2.(*loggingT).output(0x51dab80, 0xc000000003, 0x0, 0x0, 0xc0015dcb60, 0x4d64e92, 0xa, 0x73, 0x419700)
	/go/src/github.com/openshift/oc/vendor/k8s.io/klog/v2/klog.go:945 +0x19d
k8s.io/klog/v2.(*loggingT).printDepth(0x51dab80, 0x3, 0x0, 0x0, 0x2, 0xc00191f9e0, 0x1, 0x1)
	/go/src/github.com/openshift/oc/vendor/k8s.io/klog/v2/klog.go:718 +0x15e
k8s.io/klog/v2.FatalDepth(...)

jottofar · 2020-09-10T13:44:59Z

@damemi @soltysh Thanks for looking. I thought they were infra and I've seen lots of former discussion on slack about them as well but nor recent, e.g. https://coreos.slack.com/archives/CEKNRGF25/p1586344512372800

soltysh

Your bump seems incomplete, b/c it's missing go.sum being modified. Please re-run go mod tidy pointing library-go to master and it should pick all the necessary changes. It's also possible that the necessary library-go changes landed already during recent bumps.

damemi · 2020-09-14T15:29:11Z

It's also possible that the necessary library-go changes landed already during recent bumps.

@soltysh I think this is the case, because I was talking with @jottofar offline about this PR before we got the 1.19 bump in place. Wouldn't hurt to double-check though

jottofar · 2020-09-14T16:12:13Z

@soltysh Yeah, I picked up the changes to go.mod from @damemi:

$ git tattle go.mod
...
0384c91 (Maciej Szulik 2020-02-19 11:34:48 +0100 41) github.com/mtrmac/gpgme v0.1.2 // indirect
e4de4fa (Maciej Szulik 2019-09-22 13:37:21 +0200 42) github.com/opencontainers/go-digest v1.0.0-rc1
91ed2df (Mike Dame 2020-09-08 08:46:30 -0400 43) github.com/openshift/api v0.0.0-20200901182017-7ac89ba6b971
91ed2df (Mike Dame 2020-09-08 08:46:30 -0400 44) github.com/openshift/build-machinery-go v0.0.0-20200819073603-48aa266c95f7
91ed2df (Mike Dame 2020-09-08 08:46:30 -0400 45) github.com/openshift/client-go v0.0.0-20200827190008-3062137373b5
91ed2df (Mike Dame 2020-09-08 08:46:30 -0400 46) github.com/openshift/library-go v0.0.0-20200907120738-ea57b121ba1a
...
$ git log
commit 74a8213 (HEAD -> ota-193, origin/ota-193)
Author: Jack Ottofaro jottofar@redhat.com
Date: Wed Sep 9 11:45:07 2020 -0400

Clean up and modify to use library-go verify package

Modify to use proper k8s encoding/decoding and other minor cleanup.
Reference open comments from #343.
Use library-go verify package which was created since both CVO and
the oc client use them.

commit b90dcf9
Author: Jack Ottofaro jottofar@redhat.com
Date: Wed Sep 9 11:42:16 2020 -0400

Bump library-go to pick up new verify package

Did:

$ go mod tidy
$ go mod vendor

commit 20df740 (upstream/master, origin/master, origin/HEAD, master)
Merge: 40679be 4e35f1e
Author: OpenShift Merge Robot openshift-merge-robot@users.noreply.github.com
Date: Wed Sep 9 09:18:47 2020 -0400

Merge pull request #547 from damemi/oc-4.6-k8s-1.19-rebase

Bug 1874056: Rebase k8s to 1.19.0

commit 40679be (upstream/release-4.7, upstream/release-4.6)

jottofar · 2020-09-14T19:58:30Z

/unhold

soltysh · 2020-09-15T10:57:31Z

@jottofar still you're missing go.sum modifications, this file holds check sums for all the dependencies go.mod resolved.

soltysh · 2020-09-15T11:06:07Z

Compare #567, for example.

jottofar · 2020-09-15T13:44:35Z

@soltysh gotcha. Believe I have it right now in commit 06d1694.

soltysh

/lgtm
/approve

jottofar · 2020-09-15T14:41:32Z

/test build-rpms-from-tar

openshift-bot · 2020-09-15T14:43:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-15T15:08:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-15T15:35:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-15T16:52:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-15T17:18:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-15T19:02:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-15T19:41:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-15T20:07:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-15T20:20:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-15T20:33:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

Did: $ go mod tidy $ go mod vendor

Modify to use proper k8s encoding/decoding and other minor cleanup. Reference open comments from openshift#343. Use library-go verify package which was created since both CVO and the oc client use them.

jottofar · 2020-09-15T21:10:52Z

@soltysh #567 merged so I had to rebase

soltysh

/lgtm

openshift-ci-robot · 2020-09-16T10:38:27Z

@jottofar: This pull request references Bugzilla bug 1874056, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1874056: Clean up and modify to use library-go verify package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-16T10:38:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-16T13:01:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-16T13:27:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-16T14:48:49Z

@jottofar: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-authentication-operator#347 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1874056 has not been moved to the MODIFIED state.

In response to this:

Bug 1874056: Clean up and modify to use library-go verify package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from deads2k and mfojtik August 26, 2020 19:51

jottofar force-pushed the ota-193 branch from 35046e9 to 0a5d0b7 Compare August 26, 2020 20:14

jottofar force-pushed the ota-193 branch from bd9cb43 to 0a5d0b7 Compare August 31, 2020 16:32

jottofar force-pushed the ota-193 branch from 0a5d0b7 to 74a8213 Compare September 9, 2020 15:46

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2020

soltysh requested changes Sep 14, 2020

View reviewed changes

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2020

jottofar force-pushed the ota-193 branch from 74a8213 to a518ad0 Compare September 15, 2020 13:41

soltysh approved these changes Sep 15, 2020

View reviewed changes

openshift-ci-robot assigned soltysh Sep 15, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 15, 2020

jottofar added 2 commits September 15, 2020 17:03

Bump library-go to pick up new verify package

ba3429c

Did: $ go mod tidy $ go mod vendor

Clean up and modify to use library-go verify package

a154b62

Modify to use proper k8s encoding/decoding and other minor cleanup. Reference open comments from openshift#343. Use library-go verify package which was created since both CVO and the oc client use them.

jottofar force-pushed the ota-193 branch from a518ad0 to a154b62 Compare September 15, 2020 21:04

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2020

soltysh approved these changes Sep 16, 2020

View reviewed changes

soltysh changed the title ~~Clean up and modify to use library-go verify package~~ Bug 1874056: Clean up and modify to use library-go verify package Sep 16, 2020

openshift-merge-robot merged commit e973b42 into openshift:master Sep 16, 2020

openshift-ci-robot mentioned this pull request Sep 17, 2020

bug 1874056: add debugging for machine-api, mco, and node teams openshift/cluster-kube-controller-manager-operator#448

Merged

Bug 1874056: Clean up and modify to use library-go verify package #535

Bug 1874056: Clean up and modify to use library-go verify package #535

Conversation

jottofar commented Aug 26, 2020

jottofar commented Aug 26, 2020

jottofar commented Aug 31, 2020

jottofar commented Sep 9, 2020

damemi commented Sep 9, 2020

jottofar commented Sep 9, 2020

jottofar commented Sep 10, 2020

jottofar commented Sep 10, 2020

damemi commented Sep 10, 2020 • edited

jottofar commented Sep 10, 2020

soltysh left a comment

Choose a reason for hiding this comment

damemi commented Sep 14, 2020

jottofar commented Sep 14, 2020 • edited

jottofar commented Sep 14, 2020

soltysh commented Sep 15, 2020

soltysh commented Sep 15, 2020

jottofar commented Sep 15, 2020

soltysh left a comment

Choose a reason for hiding this comment

jottofar commented Sep 15, 2020

openshift-bot commented Sep 15, 2020

openshift-bot commented Sep 15, 2020

openshift-bot commented Sep 15, 2020

openshift-bot commented Sep 15, 2020

openshift-bot commented Sep 15, 2020

openshift-bot commented Sep 15, 2020

openshift-bot commented Sep 15, 2020

openshift-bot commented Sep 15, 2020

openshift-bot commented Sep 15, 2020

openshift-bot commented Sep 15, 2020

jottofar commented Sep 15, 2020

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Sep 16, 2020

openshift-ci-robot commented Sep 16, 2020

openshift-bot commented Sep 16, 2020

openshift-bot commented Sep 16, 2020

openshift-ci-robot commented Sep 16, 2020

damemi commented Sep 10, 2020 •

edited

jottofar commented Sep 14, 2020 •

edited