Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1874293: pkg/cli/admin/upgrade/: Mention Upgradeable=False #541

Merged
merged 1 commit into from Sep 1, 2020
Merged

Bug 1874293: pkg/cli/admin/upgrade/: Mention Upgradeable=False #541

merged 1 commit into from Sep 1, 2020

Conversation

wking
Copy link
Member

@wking wking commented Aug 31, 2020

When Upgradeable=False, the cluster-version operator will block (usually) minor version bumps. Sometimes it will block all version bumps. Users running oc adm upgrade should be notified about these conditions, so they are not surprised if they choose a target and the CVO subsequently blocks the chosen update.

@openshift-ci-robot
Copy link

@wking: This pull request references Bugzilla bug 1874293, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1874293: pkg/cli/admin/upgrade/: Mention Upgradeable=False

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 31, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@wking
Copy link
Member Author

wking commented Aug 31, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 31, 2020
@openshift-ci-robot
Copy link

@wking: This pull request references Bugzilla bug 1874293, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 31, 2020
@wking
pkg/cli/admin/upgrade/: Mention Upgradeable=False
128a747 
When 'Upgradeable=False', the cluster-version operator will block
(usually) minor version bumps.  Sometimes it will block all version
bumps [1].  Users running 'oc adm upgrade' should be notified about
these conditions, so they are not surprised if they choose a target
and the CVO subsequently blocks the chosen update [2].

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1822844
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1874293
soltysh
soltysh approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dfb0b7a into openshift:master Sep 1, 2020
@openshift-ci-robot
Copy link

@wking: All pull requests linked via external trackers have merged:

Bugzilla bug 1874293 has been moved to the MODIFIED state.

In response to this:

Bug 1874293: pkg/cli/admin/upgrade/: Mention Upgradeable=False

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the mention-upgradeable-false branch September 1, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wking @openshift-ci-robot @soltysh @openshift-merge-robot