Bug 1884270: bypass golang url parsing with scp styled ssh git URLs; refactor URL for older git clients

[gabemontero]

Turns our we do not vendor in openshift/source-to-image, but copy some of its packages into openshift/oc

Assuming there is a rationale / history on that, and am not going to bother altering the apporach.

So I'm porting our recent fix openshift/source-to-image@129c90e

/assign @adambkaplan
/assign @soltysh

[openshift-ci-robot]

@gabemontero: This pull request references Bugzilla bug 1884270, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1884270: port openshift/source-to-image@129c90e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adambkaplan]

PR needs a clearer title, otherwise looks good.

[openshift-ci-robot]

@gabemontero: This pull request references Bugzilla bug 1884270, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1884270: port openshift/source-to-image@129c90e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

PR needs a clearer title, otherwise looks good.

moved commit reference to PR initial description / comment and updated PR title

[adambkaplan]

/lgtm

[gabemontero]

/retest

[gabemontero]

/retest

[soltysh]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@gabemontero: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/builder#179 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1884270 has not been moved to the MODIFIED state.

In response to this:

Bug 1884270: bypass golang url parsing with scp styled ssh git URLs; refactor URL for older git clients

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.