Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1888738: fall-back must-gather to official RH supported image #627

Merged
merged 1 commit into from Oct 31, 2020

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Oct 29, 2020

This is the only reasonable image we can probably fall-back to, although I'm a bit hesitant on using it here.

/assign @wking

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Oct 29, 2020
@openshift-ci-robot
Copy link

@soltysh: This pull request references Bugzilla bug 1888738, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1888738: fall-back must-gather to official RH supported image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 29, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020
@wking
Copy link
Member

wking commented Oct 29, 2020

Why are we hesitant? This looks good to me vs. multi-arch:

$ oc image info registry.redhat.io/openshift4/ose-must-gather:latest
error: the image is a manifest list and contains multiple images - use --filter-by-os to select from:

  OS            DIGEST
  linux/amd64   sha256:fa63640328598f72567027e9cd0d50f00d4ec058dacc61f3be3c6cca7fbefac5
  linux/ppc64le sha256:d295b7b77efd2d5898b317d8759164f1169eccfae0327fde6a4f88b9e22ba583
  linux/s390x   sha256:7422ca5a2a63d10854fb5d7f2d8eb5e1978bbf65cd16aaf6a771c24bf8113e96

Although it still appears to be unsigned, using the sigstore location from this blog post:

$ curl -i https://access.redhat.com/webassets/docker/content/sigstore/openshift4/ose-must-gather@sha256:fa63640328598f72567027e9cd0d50f00d4ec058dacc61f3be3c6cca7fbefac5/signature-1
HTTP/1.1 404 Not Found
Accept-Ranges: bytes
Content-Length: 10
Server: AkamaiNetStorage
Date: Thu, 29 Oct 2020 17:55:34 GMT
Connection: keep-alive
X-Docker-Size: -1

Not found

Still, ART-built, multi-arch, and unsigned seems like an improvement over single-arch, CI-built, and unsigned.

@soltysh
Copy link
Member Author

soltysh commented Oct 30, 2020

@wking feel free to tag then ;)

@wking
Copy link
Member

wking commented Oct 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member Author

soltysh commented Oct 30, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a0d1acb into openshift:master Oct 31, 2020
@openshift-ci-robot
Copy link

@soltysh: All pull requests linked via external trackers have merged:

Bugzilla bug 1888738 has been moved to the MODIFIED state.

In response to this:

Bug 1888738: fall-back must-gather to official RH supported image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants