New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1888738: fall-back must-gather to official RH supported image #627
Conversation
@soltysh: This pull request references Bugzilla bug 1888738, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Why are we hesitant? This looks good to me vs. multi-arch: $ oc image info registry.redhat.io/openshift4/ose-must-gather:latest
error: the image is a manifest list and contains multiple images - use --filter-by-os to select from:
OS DIGEST
linux/amd64 sha256:fa63640328598f72567027e9cd0d50f00d4ec058dacc61f3be3c6cca7fbefac5
linux/ppc64le sha256:d295b7b77efd2d5898b317d8759164f1169eccfae0327fde6a4f88b9e22ba583
linux/s390x sha256:7422ca5a2a63d10854fb5d7f2d8eb5e1978bbf65cd16aaf6a771c24bf8113e96 Although it still appears to be unsigned, using the sigstore location from this blog post: $ curl -i https://access.redhat.com/webassets/docker/content/sigstore/openshift4/ose-must-gather@sha256:fa63640328598f72567027e9cd0d50f00d4ec058dacc61f3be3c6cca7fbefac5/signature-1
HTTP/1.1 404 Not Found
Accept-Ranges: bytes
Content-Length: 10
Server: AkamaiNetStorage
Date: Thu, 29 Oct 2020 17:55:34 GMT
Connection: keep-alive
X-Docker-Size: -1
Not found Still, ART-built, multi-arch, and unsigned seems like an improvement over single-arch, CI-built, and unsigned. |
@wking feel free to tag then ;) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@soltysh: All pull requests linked via external trackers have merged: Bugzilla bug 1888738 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is the only reasonable image we can probably fall-back to, although I'm a bit hesitant on using it here.
/assign @wking