New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REVERT: Bug 1812813: oc debug node: create debug namespace with empty node-selector annotation #550 #668
REVERT: Bug 1812813: oc debug node: create debug namespace with empty node-selector annotation #550 #668
Conversation
… node-selector annotation openshift#550 As discussed in the bugzilla report, creating the debug namespace that can override admin configured defaultNodeSelector gives too much privilege to oc. We are reverting this change in favor of the original workaround, that is, for the admin to create a new debug namespace with the empty node-selector and then direct oc to use that namespace for debugging. $ oc adm new-project debug --node-selector="" $ oc debug node/<node> -n debug
@sallyom: This pull request references Bugzilla bug 1812813, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold will also add code to warn/direct users to workaround |
Let's revert in a separate PR and add back in the other. The warn should be generic anyway (pod didn't get scheduled in X time or pod was rejected can both happen for many reasons) |
We'll want to cherry-pick that to 4.6 so I wanted to have those together. |
/hold cancel |
@soltysh the error returned when debug node creates a pod that doesn't satisfy the default node selector set is ambiguous, pod is created w/out error then completes, it's this: https://github.com/openshift/oc/blob/master/pkg/cli/debug/debug.go#L553 with err https://github.com/openshift/oc/blob/master/vendor/k8s.io/kubectl/pkg/cmd/run/run.go#L688-#L690 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sallyom: All pull requests linked via external trackers have merged: Bugzilla bug 1812813 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As discussed in the bugzilla report, creating the debug namespace that can override admin configured defaultNodeSelector gives too much privilege to oc and breaks the contract of debug in that you change the context you are running in.
We are reverting this change in favor of the original workaround, that is, for the admin to create a new debug namespace with the empty node-selector and then direct oc to use that namespace for debugging.