Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REVERT: Bug 1812813: oc debug node: create debug namespace with empty node-selector annotation #550 #668

Merged

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Dec 11, 2020

As discussed in the bugzilla report, creating the debug namespace that can override admin configured defaultNodeSelector gives too much privilege to oc and breaks the contract of debug in that you change the context you are running in.
We are reverting this change in favor of the original workaround, that is, for the admin to create a new debug namespace with the empty node-selector and then direct oc to use that namespace for debugging.

$ oc adm new-project debug --node-selector=""
$ oc debug node/<node> -n debug

… node-selector annotation openshift#550

As discussed in the bugzilla report, creating the debug namespace that can override admin configured defaultNodeSelector gives too much privilege to oc.
We are reverting this change in favor of the original workaround, that is, for the admin to create a new debug namespace with the empty node-selector
and then direct oc to use that namespace for debugging.

$ oc adm new-project debug --node-selector=""
$ oc debug node/<node> -n debug
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 11, 2020
@openshift-ci-robot
Copy link

@sallyom: This pull request references Bugzilla bug 1812813, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

REVERT: Bug 1812813: oc debug node: create debug namespace with empty node-selector annotation #550

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 11, 2020
@sallyom
Copy link
Contributor Author

sallyom commented Dec 11, 2020

/hold

will also add code to warn/direct users to workaround

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2020
@smarterclayton
Copy link
Contributor

Let's revert in a separate PR and add back in the other. The warn should be generic anyway (pod didn't get scheduled in X time or pod was rejected can both happen for many reasons)

@soltysh
Copy link
Member

soltysh commented Dec 15, 2020

Let's revert in a separate PR and add back in the other. The warn should be generic anyway (pod didn't get scheduled in X time or pod was rejected can both happen for many reasons)

We'll want to cherry-pick that to 4.6 so I wanted to have those together.

@sallyom
Copy link
Contributor Author

sallyom commented Dec 17, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020
@sallyom
Copy link
Contributor Author

sallyom commented Dec 17, 2020

@soltysh the error returned when debug node creates a pod that doesn't satisfy the default node selector set is ambiguous, pod is created w/out error then completes, it's this: https://github.com/openshift/oc/blob/master/pkg/cli/debug/debug.go#L553 with err https://github.com/openshift/oc/blob/master/vendor/k8s.io/kubectl/pkg/cmd/run/run.go#L688-#L690
To get a better error will take some refactoring, maybe it's best in a separate PR.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5eda527 into openshift:master Dec 17, 2020
@openshift-ci-robot
Copy link

@sallyom: All pull requests linked via external trackers have merged:

Bugzilla bug 1812813 has been moved to the MODIFIED state.

In response to this:

REVERT: Bug 1812813: oc debug node: create debug namespace with empty node-selector annotation #550

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants