[WIP] oc.spec: fix for openshift-clients build #70
Conversation
|
@sosiouxme: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sosiouxme The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -12,7 +12,7 @@ include $(addprefix ./vendor/github.com/openshift/library-go/alpha-build-machine | |||
| GO_LD_EXTRAFLAGS :=-X github.com/openshift/oc/vendor/k8s.io/kubernetes/pkg/version.gitMajor="1" \ | |||
| -X github.com/openshift/oc/vendor/k8s.io/kubernetes/pkg/version.gitMinor="14" \ | |||
| -X github.com/openshift/oc/vendor/k8s.io/kubernetes/pkg/version.gitVersion="v1.14.0+724e12f93f" \ | |||
| -X github.com/openshift/oc/vendor/k8s.io/kubernetes/pkg/version.gitCommit="$(SOURCE_GIT_COMMIT)" \ | |||
There was a problem hiding this comment.
yeah, this wont work - let me send a PR to set those properly
| @@ -8,10 +8,25 @@ | |||
|
|
|||
| %global golang_version 1.12 | |||
| %global product_name OpenShift | |||
| %global package_name openshift-clients | |||
There was a problem hiding this comment.
why is this needed / where is it used?
There was a problem hiding this comment.
it may not be. i was just cargo-culting it from origin thinking it might influence the %{name} macro but it probably does nothing.
|
reworked the other changes into #71 |
|
@sosiouxme: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
superseded |
No description provided.