Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1739445: Fix oc rpm for ART builds #71

Merged
merged 1 commit into from Aug 28, 2019
Merged

Bug 1739445: Fix oc rpm for ART builds #71

merged 1 commit into from Aug 28, 2019

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Aug 27, 2019 •
edited

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 27, 2019
@tnozicka tnozicka changed the title [WIP] - Fix oc rpm for ART builds [WIP] - Bug 1739445: Fix oc rpm for ART builds Aug 27, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 27, 2019
@openshift-ci-robot
Copy link

@tnozicka: This pull request references Bugzilla bug 1739445, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[WIP] - Bug 1739445: Fix oc rpm for ART builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka tnozicka mentioned this pull request Aug 27, 2019
Closed
tnozicka
tnozicka commented Aug 27, 2019
View reviewed changes
oc.spec Outdated Show resolved Hide resolved
@tnozicka tnozicka mentioned this pull request Aug 27, 2019
Merged
@tnozicka
Copy link
Contributor Author

/retest

@tnozicka
Copy link
Contributor Author

/test test-rpms
/test images

@tnozicka
Copy link
Contributor Author

/refresh

@tnozicka
Copy link
Contributor Author

/test test-rpms

1 similar comment
@tnozicka
Copy link
Contributor Author

/test test-rpms

@tnozicka tnozicka changed the title [WIP] - Bug 1739445: Fix oc rpm for ART builds Bug 1739445: Fix oc rpm for ART builds Aug 27, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2019
soltysh
soltysh approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
sosiouxme
sosiouxme reviewed Aug 27, 2019
View reviewed changes
oc.spec Outdated Show resolved Hide resolved
@tnozicka tnozicka changed the title Bug 1739445: Fix oc rpm for ART builds [WIP] - Bug 1739445: Fix oc rpm for ART builds Aug 27, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2019
@tnozicka tnozicka force-pushed the fix-oc-rpm-for-art branch 2 times, most recently from 18e9d2f to 68152ec Compare August 27, 2019 16:53
@tnozicka
Copy link
Contributor Author

/retest

@tnozicka
Copy link
Contributor Author

/retest

@tnozicka tnozicka changed the title [WIP] - Bug 1739445: Fix oc rpm for ART builds Bug 1739445: Fix oc rpm for ART builds Aug 28, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2019
soltysh
soltysh approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2019
@tnozicka
Copy link
Contributor Author

/hold
I found another thing missing

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2019
@tnozicka tnozicka changed the title Bug 1739445: Fix oc rpm for ART builds [WIP] - Bug 1739445: Fix oc rpm for ART builds Aug 28, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2019
@openshift-ci-robot
Copy link

@tnozicka: This pull request references Bugzilla bug 1739445, which is valid.

In response to this:

[WIP] - Bug 1739445: Fix oc rpm for ART builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka
Copy link
Contributor Author

/hold cancel
(updated)

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2019
@openshift-ci-robot
Copy link

@tnozicka: This pull request references Bugzilla bug 1739445, which is valid.

In response to this:

[WIP] - Bug 1739445: Fix oc rpm for ART builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka tnozicka changed the title [WIP] - Bug 1739445: Fix oc rpm for ART builds Bug 1739445: Fix oc rpm for ART builds Aug 28, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 28, 2019
soltysh
soltysh approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka tnozicka mentioned this pull request Aug 28, 2019
Merged
@openshift-merge-robot openshift-merge-robot merged commit 372c08a into openshift:master Aug 28, 2019
@tnozicka tnozicka deleted the fix-oc-rpm-for-art branch August 28, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosiouxme sosiouxme sosiouxme left review comments

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tnozicka @openshift-ci-robot @sosiouxme @soltysh @openshift-merge-robot