Bug 1917548: 4.6 backports for oc adm catalog mirror #711
Conversation
previously this mirrored one image at a time
openshift-ci-robot
added
bugzilla/severity-medium
|
@ecordell: This pull request references Bugzilla bug 1832968, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
ecordell
changed the title
openshift-ci-robot
added
bugzilla/valid-bug
|
@ecordell: This pull request references Bugzilla bug 1917547, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ecordell: This pull request references Bugzilla bug 1917547, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@ecordell: This pull request references Bugzilla bug 1917547, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ecordell
force-pushed
the
46-airgap-catalog
branch
from
ff40952
to
5cebef2
Compare
openshift-ci-robot
removed
the
approved
ecordell
changed the title
openshift-ci-robot
added
bugzilla/severity-urgent
|
@ecordell: This pull request references Bugzilla bug 1917548, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
the `Parse` function from library go prefers parsing ambiguous names as repositories for mirroring use-cases, we want to prefer parsing ambiguous names as registries. for example: `oc adm catalog mirror my-index:1 quay.io` should parse `quay.io` as a registry name, not as `docker.io/library/quay.io` the ambiguity can always be resolved by a user manually if needed by fully qualifying a name they intended to be parsed as a repository
this ensures that the mirrored manifests can still reference the manifestlist by digest
does not filter the mirrored images
ecordell
force-pushed
the
46-airgap-catalog
branch
from
5cebef2
to
22cebdd
Compare
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
jwforres
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
In case anyone is looking at this PR waiting for a fix, this KCS article should address the issue in the meantime. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
IAM is a known problem already reported to appropriate team, since the test-cmd is currently flaking heavily and a fix is already in the queue for 4.6 openshift/origin#25831 I'm overriding that particular test to unblock this pick /override ci/prow/e2e-agnostic-cmd |
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-agnostic-cmd In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws |
1 similar comment
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ecordell: All pull requests linked via external trackers have merged: Bugzilla bug 1917548 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR contains fixes from #611 and #673, which together address the following BZs:
https://bugzilla.redhat.com/show_bug.cgi?id=1917547
https://bugzilla.redhat.com/show_bug.cgi?id=1917548
https://bugzilla.redhat.com/show_bug.cgi?id=1917549
https://bugzilla.redhat.com/show_bug.cgi?id=1917550
One commit (5c2d51c) was added to vendor the target-specific parsing we do, so that library-go didn't need to be bumped. Please see the commit message for details.