[release-4.6] Bug 1942818: when mirroring to a file destination, mount images under the index location #892
Conversation
when mirroring an index image: quay.io/my/index:a that contains a reference to another image: quay.io/other/bundle:1 to a local file: file:///local/index the referenced images are now mounted under the location for the index itself, resulting in (for example): file:///local/index/my/index:a file:///local/index/my/index/other/bundle:1 this fixes a bug where the next step of an airgap mirror can't find the images to be mirrored. as a side effect, this keeps all catalog content stored under the same fs location. Local file storage can be shared with other mirrored images while keeping it simple to copy the full contents of an index to another location.
openshift-ci
bot
added
bugzilla/severity-medium
|
@timflannagan: This pull request references Bugzilla bug 1942818, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
This PR won't pass because openshift/library-go#914 and openshift/library-go#928 have not been applied to library-go's release-4.6 branch. Working on that now. Correction: they have been in #711 but the right lib needs to be used in tests. |
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
|
/assign @soltysh |
|
/retest |
|
/approve |
openshift-ci
bot
added
bugzilla/severity-high
|
@soltysh: This pull request references Bugzilla bug 1942818, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza, soltysh, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mfojtik
added
the
cherry-pick-approved
|
[patch-manager] 🚀 Approved for z-stream by score: 0.70 adding cherry-pick approved |
|
@timflannagan: All pull requests linked via external trackers have merged: Bugzilla bug 1942818 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual cherrypick of #781 that fixes the invalid package imports in mirrored_test.go.