Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding image extract Unit tests #736

Closed
wants to merge 1 commit into from

Conversation

zerodayz
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zerodayz
To complete the pull request process, please assign mfojtik after the PR has been reviewed.
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zerodayz
Copy link
Contributor Author

This PR should contain Unit tests as requested in #713, and some more.

@zerodayz
Copy link
Contributor Author

/hold
/wip

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2021
@zerodayz zerodayz force-pushed the add_extract_test branch 3 times, most recently from 66aa3a5 to b7dec18 Compare February 10, 2021 04:37
@zerodayz
Copy link
Contributor Author

zerodayz commented Feb 10, 2021

/cc @sallyom I have created an artificial docker image intestdata folder called foobar.tar, but I have noticed that all the logic for the extraction is part of the Run() command. The Run() command expects the Docker registry. I wonder how could I inject this artificial image.

The foobar.tar contains two layers with one directory and a file and file under rootfs.
It's proper docker image:

tar -tf testdata/foobar.tar
1034fa20f0fbb9e271424c7211b4d59718a6a0d524f004be63cd9a43ee739dfc/
1034fa20f0fbb9e271424c7211b4d59718a6a0d524f004be63cd9a43ee739dfc/VERSION
1034fa20f0fbb9e271424c7211b4d59718a6a0d524f004be63cd9a43ee739dfc/json
1034fa20f0fbb9e271424c7211b4d59718a6a0d524f004be63cd9a43ee739dfc/layer.tar
a3a095226f580b68e4bd46c3a92e4b3070789376571f8ef1bb64007ab16876f7/
a3a095226f580b68e4bd46c3a92e4b3070789376571f8ef1bb64007ab16876f7/VERSION
a3a095226f580b68e4bd46c3a92e4b3070789376571f8ef1bb64007ab16876f7/json
a3a095226f580b68e4bd46c3a92e4b3070789376571f8ef1bb64007ab16876f7/layer.tar
a80a2c9c681aab344887dc54203989e213e508d13e23109ebfc129f5a049f898.json
manifest.json
repositories

Thank you!

@zerodayz zerodayz marked this pull request as draft February 10, 2021 05:04
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2021
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 12, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jul 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2021

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants