release: Fix verification errors when excluding components #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing --exclude resulted in a verification error because changing those rules didn't correctly detect that the output is expected to differ. Instead, we should skip if a user specifies any variants. Also remove the need to declare "AlwaysInclude", manually verified that it created the same output.
|
/assign @abhinavdahiya |
openshift-ci-robot
added
size/S
| // another operator. | ||
| AlwaysInclude: []string{"cluster-version-operator", "cli", "installer"}, | ||
| ToImageBaseTag: "cluster-version-operator", | ||
| ToImageBaseTag: "cluster-version-operator", |
There was a problem hiding this comment.
Hmm, i am a little surprised as to what changed that the installer always include is not required anymore.. which operator image is requesting this image... looking
There was a problem hiding this comment.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing --exclude resulted in a verification error because changing
those rules didn't correctly detect that the output is expected to
differ. Instead, we should skip if a user specifies any variants.
Also remove the need to declare "AlwaysInclude", manually verified
that it created the same output.
Needed for creating fake payloads during upgrade testing that lack
machine-config-operator.