Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1978629: Add oc describe output for build volumes #874

Merged
merged 1 commit into from Jul 15, 2021
Merged

Bug 1978629: Add oc describe output for build volumes #874

merged 1 commit into from Jul 15, 2021

Conversation

coreydaley
Copy link
Member

@coreydaley coreydaley commented Jul 2, 2021 •
edited

Adding oc describe output for build volumes
Adding tests for oc describe output for build volumes
Adding _tmp to .gitignore

Sample oc describe output for a build config: https://pastebin.com/1TeAfvku
Sample oc describe output for a build: https://pastebin.com/vEDEUhhq

@coreydaley
Copy link
Member Author

/assign @soltysh @deads2k

@coreydaley coreydaley changed the title BUILD-87: Secret Volume Mounts in Builds BUILD-87: Add oc describe output for build volumes Jul 2, 2021
@coreydaley coreydaley changed the title BUILD-87: Add oc describe output for build volumes Bug 1978629: Add oc describe output for build volumes Jul 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@coreydaley: This pull request references Bugzilla bug 1978629, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1978629: Add oc describe output for build volumes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 2, 2021
@coreydaley
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@coreydaley: This pull request references Bugzilla bug 1978629, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coreydaley
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@coreydaley: This pull request references Bugzilla bug 1978629, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from xiuwang July 2, 2021 17:46
@coreydaley
Copy link
Member Author

/retest

coreydaley
coreydaley commented Jul 3, 2021
View reviewed changes
.gitignore Show resolved Hide resolved
@xiuwang
Copy link

xiuwang commented Jul 6, 2021

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 6, 2021
@coreydaley
Copy link
Member Author

@soltysh @deads2k bump

@coreydaley coreydaley force-pushed the jira_build_87_secret_configmap_volume_mounts_in_builds_2 branch from 97ff323 to 314f484 Compare July 9, 2021 14:22
@coreydaley
Copy link
Member Author

/retest

5 similar comments
@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley coreydaley force-pushed the jira_build_87_secret_configmap_volume_mounts_in_builds_2 branch from 314f484 to 7755b02 Compare July 12, 2021 18:54
@coreydaley
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2021
@coreydaley coreydaley force-pushed the jira_build_87_secret_configmap_volume_mounts_in_builds_2 branch from 7755b02 to 3bb41c8 Compare July 14, 2021 00:28
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2021
@coreydaley
Copy link
Member Author

/retest

soltysh
soltysh requested changes Jul 14, 2021
View reviewed changes
pkg/helpers/describe/describer.go Outdated Show resolved Hide resolved
@coreydaley coreydaley force-pushed the jira_build_87_secret_configmap_volume_mounts_in_builds_2 branch from 3bb41c8 to 93d3c39 Compare July 14, 2021 15:51
@coreydaley
BUILD-87: Secret Volume Mounts in Builds
be5246b 
Adding `oc describe` output for build volumes
Adding tests for `oc describe` output for build volumes
Adding `_tmp` to .gitignore
@coreydaley coreydaley force-pushed the jira_build_87_secret_configmap_volume_mounts_in_builds_2 branch from 93d3c39 to be5246b Compare July 14, 2021 16:00
soltysh
soltysh approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@coreydaley
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021 •
edited

@coreydaley: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 be5246b link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@coreydaley
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 07ff43c into openshift:master Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

@coreydaley: All pull requests linked via external trackers have merged:

Bugzilla bug 1978629 has been moved to the MODIFIED state.

In response to this:

Bug 1978629: Add oc describe output for build volumes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coreydaley
Copy link
Member Author

Holy guacamole! It finally merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@xiuwang xiuwang Awaiting requested review from xiuwang

Assignees

@soltysh soltysh

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@coreydaley @xiuwang @openshift-bot @soltysh @deads2k @openshift-merge-robot