Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1992680: pkg/cli/admin/upgrade/upgrade: Copy edits, including "assists with cluster upgrades" #899

Merged
merged 1 commit into from Aug 16, 2021

Commits on Aug 16, 2021

  1. pkg/cli/admin/upgrade/upgrade: Copy edits, including "assists with cl…

    …uster upgrades"
    
    The previous:
    
      This command will request that the cluster begin an upgrade...
    
    and similar confused some readers [1], because the no-argument
    invocation is just a read query that does not request an update.  This
    commit makes the wording more generic, to match the subcommand's
    actual generic functionality (reading from and optionally writing to
    ClusterVersion).
    
    I've also tweaked the "No updates available" message to avoid folks
    misreading as:
    
      ... doing so may not... result in downtime or data loss.
    
    when we are trying to convey that updating despite a lack of
    recommendations might be dangerous.
    
    In both cases, the wording I'm altering dates back to the creation of
    this subcommand in cd30f2f (Add `oc adm upgrade` to display
    available updates or trigger an update, 2018-12-04,
    openshift/origin#21605).
    
    [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1992680#c2
    wking committed Aug 16, 2021
    Copy the full SHA
    84ba9d5 View commit details
    Browse the repository at this point in the history