Bug 1992680: pkg/cli/admin/upgrade/upgrade: Copy edits, including "assists with cluster upgrades" #899
Conversation
…uster upgrades" The previous: This command will request that the cluster begin an upgrade... and similar confused some readers [1], because the no-argument invocation is just a read query that does not request an update. This commit makes the wording more generic, to match the subcommand's actual generic functionality (reading from and optionally writing to ClusterVersion). I've also tweaked the "No updates available" message to avoid folks misreading as: ... doing so may not... result in downtime or data loss. when we are trying to convey that updating despite a lack of recommendations might be dangerous. In both cases, the wording I'm altering dates back to the creation of this subcommand in cd30f2f (Add `oc adm upgrade` to display available updates or trigger an update, 2018-12-04, openshift/origin#21605). [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1992680#c2
|
@wking: This pull request references Bugzilla bug 1992680, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-low
openshift-ci
bot
added
the
approved
|
CC @bparees, do you find the wording I'm proposing here more clear than what I'm leaving the main " |
|
it looks good to me, thank you @wking /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
I'm pretty sure /override ci/prow/e2e-agnostic-cmd But I also expect we'll eventually sneak in on retests if they're too busy. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
yeah that is on my list to chase elsewhere. /override ci/prow/e2e-agnostic-cmd |
|
@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-agnostic-cmd In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 1992680 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The previous:
and similar confused some readers, because the no-argument invocation is just a read query that does not request an update. This commit makes the wording more generic, to match the subcommand's actual generic functionality (reading from and optionally writing to ClusterVersion).
I've also tweaked the "No updates available" message to avoid folks misreading as:
when we are trying to convey that updating despite a lack of recommendations might be dangerous.
In both cases, the wording I'm altering dates back to the creation of this subcommand in cd30f2f (openshift/origin#21605).