Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goreleaser/template to v2 #292

Merged

Conversation

clcollins
Copy link
Member

Update to use Goreleaser version 2. I've tested this locally and has been working. This will require TLs to update their Goreleaser version in use to v2. Goreleaser will refuse to run v2 templates with v1, so it will be clear to them if they haven't yet updated.

Signed-off-by: Chris Collins collins.christopher@gmail.com

@openshift-ci openshift-ci bot requested review from AlexVulaj and T0MASD June 6, 2024 18:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@clcollins
Copy link
Member Author

Depends on https://github.com/openshift/backplane-tools releasing v1.1.0++ with the rosa-cli fix.

Update to use Goreleaser version 2.  I've tested this locally and has been working.  This will require TLs to update their Goreleaser version in use to v2.  Goreleaser will refuse to run v2 templates with v1, so it will be clear to them if they haven't yet updated.

Signed-off-by: Chris Collins <collins.christopher@gmail.com>
@rendhalver
Copy link
Contributor

/retest

@rendhalver
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, rendhalver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [clcollins,rendhalver]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5a09972 into openshift:master Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants