Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-677: Remove _output dir removal #2366

Merged
merged 1 commit into from
Dec 15, 2022
Merged

USHIFT-677: Remove _output dir removal #2366

merged 1 commit into from
Dec 15, 2022

Conversation

pmtk
Copy link

@pmtk pmtk commented Dec 13, 2022

Partial revert of #2364. Removal of _output dir will be handled in rebase.sh - see openshift/microshift#1191

@pmtk
USHIFT-677: Remove _output dir removal
4b37c4f 
Removal of _output dir will be handled in rebase.sh
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022 •
edited

@pmtk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

USHIFT-677: Remove _output dir removal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Author

pmtk commented Dec 13, 2022

/cc @vfreex @joepvd

@openshift-ci openshift-ci bot requested review from joepvd and vfreex December 13, 2022 11:18
@pmtk
Copy link
Author

pmtk commented Dec 13, 2022

/cherry-pick openshift-4.12

@openshift-cherrypick-robot
Copy link

@pmtk: once the present PR merges, I will cherry-pick it on top of openshift-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick openshift-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Author

pmtk commented Dec 13, 2022

/hold
until PR on microshift is merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@openshift-bot
Copy link

Build #1

No files to validate

@pmtk
Copy link
Author

pmtk commented Dec 13, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@vfreex
Copy link
Contributor

vfreex commented Dec 15, 2022

/lgtm

@vfreex vfreex merged commit 380da84 into openshift-eng:openshift-4.13 Dec 15, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 15, 2022
Merged
@openshift-cherrypick-robot
Copy link

@pmtk: new pull request created: #2373

In response to this:

/cherry-pick openshift-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepvd joepvd Awaiting requested review from joepvd

@vfreex vfreex Awaiting requested review from vfreex

Assignees

@vfreex vfreex

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmtk @openshift-cherrypick-robot @openshift-bot @vfreex