Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1942519:[release-4.7] Enable Noobaa KMS configuration only when the cluster-wide encryption is enabled #1138

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1133

/assign agarwal-mudit

… is enabled

Noobaa's root secret key, used for MCG encryption, should only  be
stored in to KMS server only if cluster wide encryption with StorageClass
encryption enabled.
Corrected the test cases accordingly.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@agarwal-mudit
Copy link
Member

/retitle Bug 1942519:[release-4.7] Enable Noobaa KMS configuration only when the cluster-wide encryption is enabled

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Enable Noobaa KMS configuration only when the cluster-wide encryption is enabled Bug 1942519:[release-4.7] Enable Noobaa KMS configuration only when the cluster-wide encryption is enabled Mar 26, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Mar 26, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1942519, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (OCS 4.7.0) matches configured target release for branch (OCS 4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 1942519:[release-4.7] Enable Noobaa KMS configuration only when the cluster-wide encryption is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 26, 2021
@agarwal-mudit
Copy link
Member

/assign jarrpa

Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit e8df82d into red-hat-storage:release-4.7 Mar 26, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1942519 has been moved to the MODIFIED state.

In response to this:

Bug 1942519:[release-4.7] Enable Noobaa KMS configuration only when the cluster-wide encryption is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants