Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to use empty labelSelector #557

Merged
merged 3 commits into from Jun 10, 2020
Merged

Fixes to use empty labelSelector #557

merged 3 commits into from Jun 10, 2020

Conversation

anubhav-here-zz
Copy link
Contributor

@anubhav-here-zz anubhav-here-zz commented Jun 9, 2020 •
edited

umangachapagain
umangachapagain reviewed Jun 10, 2020
View reviewed changes
pkg/controller/defaults/placements.go Outdated
},
},
// DefaultNodeSelector is the NodeAffinity to be used when labelSelector is nil
DefaultNodeSelector = &corev1.NodeAffinity{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is DefaultNodeAffinity, why name it DefaultNodeSelector?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Will fix that

@anubhav-here-zz anubhav-here-zz force-pushed the fix-labelselector branch 2 times, most recently from 6c0d3ed to 27211e6 Compare June 10, 2020 08:34
jarrpa
jarrpa requested changes Jun 10, 2020
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. For the TestGetPlacement() test, add another case #5 to test that an empty but non-nil LabelSelector sets no NodeAffinity in the resulting Placement.

@anubhav-here-zz
Modified to use empty labelSelector
d3a5ea9 
Signed-off-by: Anubhav Deep <adeep@redhat.com>
@anubhav-here-zz
Updated unit tests
456eef2 
Signed-off-by: Anubhav Deep <adeep@redhat.com>
@anubhav-here-zz
Updated CRDs and gen latest CSVs
578142f 
Signed-off-by: Anubhav Deep <adeep@redhat.com>
jarrpa
jarrpa approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubhav-here, jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit e435d32 into red-hat-storage:master Jun 10, 2020
@anubhav-here-zz anubhav-here-zz deleted the fix-labelselector branch June 10, 2020 17:15
@raghavendra-talur
Copy link
Contributor

/cherrypick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

@raghavendra-talur: new pull request created: #575

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raghavendra-talur raghavendra-talur mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangachapagain umangachapagain umangachapagain left review comments

@jarrpa jarrpa jarrpa approved these changes

@davidvossel davidvossel Awaiting requested review from davidvossel

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

Assignees

@jarrpa jarrpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

noobaa-db-0 pod not coming up with custom labels.
7 participants
@anubhav-here-zz @openshift-ci-robot @raghavendra-talur @openshift-cherrypick-robot @jarrpa @umangachapagain @openshift-merge-robot