Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1846085: [release-4.5] Updates don't work on StorageClass #600

Merged
merged 1 commit into from Jul 3, 2020
Merged

Bug 1846085: [release-4.5] Updates don't work on StorageClass #600

merged 1 commit into from Jul 3, 2020

Conversation

rajatsing
Copy link

@rajatsing rajatsing commented Jul 2, 2020 •
edited by obnoxxx

Backport PR for commit 6e22082

Backport of PR #590

Signed-off-by: RAJAT SINGH rajasing@redhat.com

@openshift-ci-robot
Copy link

@rajatsingh25aug: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 1846085 (Backport) - Updates don't work on StorageClass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2020
@rajatsing rajatsing changed the title Bug 1846085 (Backport) - Updates don't work on StorageClass Bug 1846085:Updates don't work on StorageClass Jul 2, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 2, 2020
@openshift-ci-robot
Copy link

@rajatsingh25aug: This pull request references Bugzilla bug 1846085, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1846085 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1846085:Updates don't work on StorageClass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 2, 2020
@umangachapagain
Copy link
Contributor

/retest

Ceph(fix): Updates on StorageClass won't work.
0e9e35c 
This PR fixes the issue, where the updates given on StorageClass were not working.Now,the cluster will delete the existing sc and create a new one when requested for updation.

Signed-off-by: RAJAT SINGH <rajasing@redhat.com>
@rajatsing
Copy link
Author

@umangachapagain Should I push one more time with a new latest-csv-checksum?. The command verify-latest-csv is passing on my machine locally.

@rajatsing
Copy link
Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@rajatsingh25aug: This pull request references Bugzilla bug 1846085, which is invalid:

  • expected Bugzilla bug 1846085 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umangachapagain
Copy link
Contributor

@umangachapagain Should I push one more time with a new latest-csv-checksum?. The command verify-latest-csv is passing on my machine locally.

Push the update. CI needs to pass too.

@rajatsing
Copy link
Author

@umangachapagain Should I push one more time with a new latest-csv-checksum?. The command verify-latest-csv is passing on my machine locally.

Push the update. CI needs to pass too.

Done already 👍

@obnoxxx
Copy link
Contributor

obnoxxx commented Jul 3, 2020

/test ocs-operator-e2e-aws

@obnoxxx obnoxxx changed the title Bug 1846085:Updates don't work on StorageClass Bug 1846085: [release-4.5] Updates don't work on StorageClass Jul 3, 2020
@openshift-ci-robot
Copy link

@rajatsingh25aug: This pull request references Bugzilla bug 1846085, which is invalid:

  • expected Bugzilla bug 1846085 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1846085: [release-4.5] Updates don't work on StorageClass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

obnoxxx
obnoxxx approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: obnoxxx, rajatsingh25aug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 3, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@obnoxxx obnoxxx added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 3, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@rajatsingh25aug: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/ocs-operator-e2e-aws 0e9e35c link /test ocs-operator-e2e-aws
ci/prow/red-hat-storage-ocs-ci-e2e-aws 0e9e35c link /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit fa46d40 into red-hat-storage:release-4.5 Jul 3, 2020
@openshift-ci-robot
Copy link

@rajatsingh25aug: All pull requests linked via external trackers have merged: openshift/ocs-operator#590. Bugzilla bug 1846085 has been moved to the POST state.

In response to this:

Bug 1846085: [release-4.5] Updates don't work on StorageClass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obnoxxx obnoxxx obnoxxx approved these changes

@umangachapagain umangachapagain Awaiting requested review from umangachapagain

Assignees

@obnoxxx obnoxxx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rajatsing @openshift-ci-robot @umangachapagain @obnoxxx @openshift-bot @openshift-merge-robot